MASTmultiphysics / mast-multiphysics

Multidisciplinary-design Adaptation and Sensitivity Toolkit (MAST) - Sensitivity-enabled multiphysics FEA for design
https://www.mast-multiphysics.com
GNU Lesser General Public License v2.1
43 stars 24 forks source link

First Catch2 tests for structural 2D elements #80

Closed jdeaton closed 4 years ago

jdeaton commented 4 years ago

This PR completes the chain of additions of Catch2 tests (#60, #70, #79) for existing MAST library capability that was originally primarily implemented by @JohnDN90. The additions here are related to 2D structural elements.

Below is a checklist of commits implemented by @JohnDN90 in his add_catch2_tests branch the whose contents/functionality need rolled in. The checklist ones will be covered in this PR:

manavbhatia commented 4 years ago

Just curious why there appear to be the same changes introduced in #79 and #80.

jdeaton commented 4 years ago

Just curious why there appear to be the same changes introduced in #79 and #80.

It will go away here shortly. I wanted to get this up early while John was fixing something else over in #79. Once I merge #79 into master I'll rebase this branch on-top of the updated master and force push back to GitHub. It will wipe out those duplicated commits in this PR.

jdeaton commented 4 years ago

Merging this one now as it completes refactoring of John's initial catch tests to reduce code duplication. There is still more testing required for 2D structural elements, but it can be added later.