MATLAB-Community-Toolboxes-at-INCF / DeepInterpolation-MATLAB

A MATLAB implementation of the DeepInterpolation principle.
Other
6 stars 4 forks source link

adding back dandi_example to commits #45

Open stevevanhooser opened 10 months ago

stevevanhooser commented 10 months ago

Hi all -

These are the comments from pull request #34 that pertain to the file not merged.

In an effort to get out version 7 before Dec 15, @vijayiyer05 and I discussed setting the Dandi integration aside for a little bit.

In consultation with @vijayiyer05, the 50GB file is a bit unwieldy.

There are a few issues with downloading the dandi file.

Work can continue on the dandihub_work_0.8.0 branch, for which a draft pull request #45 has been issued.

Thanks Steve

jbentvelsen commented 10 months ago

Hi all -

These are the comments from pull request #34 that pertain to the file not merged.

In an effort to get out version 7 before Dec 15, @vijayiyer05 and I discussed setting the Dandi integration aside for a little bit.

In consultation with @vijayiyer05, the 50GB file is a bit unwieldy.

There are a few issues with downloading the dandi file.

* For me, the file doesn't download, even if I call the dandi-cli tool from my terminal.

* If we are going to ask the users to install the dandi-cli, then I think we ought to tell them how to do it so they don't have to read too much (easy as `pip install dandi`).

* The code as it is now calls the `dandi` command from Matlab via the `system` command. However, it is not on my path, and I doubt it will be on the path of many users, given that it is in the Python library. So if we're going to do that we ought to have some good solution. Not sure if telling users how to add it to their Matlab path is easier, or walking them through a download on the command line.

Work can continue on the dandihub_work_0.8.0 branch, for which a draft pull request #45 has been issued.

Thanks Steve

Hi Steve, thanks for testing this branch. Strange it does not download on your pc, do you get any specific error?

Furthermore, this branch was mainly intended to be used on dandi-hub. In that case, dandi-cli is already installed and on path. Also, downloading the 50GB file will take around 15 minutes. For users running locally, I believe there is a link to the installation instructions in the introduction text of the livescript.

Finally, if there are smaller datasets with raw data available, I agree we should use one of them.