MAVRICK-1 / EduWeb

https://edu-web-ruby.vercel.app
14 stars 20 forks source link

login page created #44

Closed Ojas-Arora closed 3 weeks ago

Ojas-Arora commented 4 weeks ago

Related Issue

Fixes #41

Description

Login/Signup Page created

Type of PR

Screenshots / videos (if applicable)

image

Checklist:

Additional context:

NA

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
edu-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 8:11am
MAVRICK-1 commented 4 weeks ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

MAVRICK-1 commented 4 weeks ago
Screenshot 2024-05-31 191706

@Ojas-Arora great word just make it responsive then it is ready to merge

Ojas-Arora commented 4 weeks ago

@MAVRICK-1 I have made page responsive and added some additional features to it. Please review

MAVRICK-1 commented 3 weeks ago

https://github.com/MAVRICK-1/EduWeb/assets/146999057/a4b81939-b464-4481-977d-40b9e83f8dd0

@Ojas-Arora

Ojas-Arora commented 3 weeks ago

What do you want to convey @MAVRICK-1 ?

MAVRICK-1 commented 3 weeks ago

What do you want to convey @MAVRICK-1 ?

Shouldn't that spinning card be hidden ?

Ojas-Arora commented 3 weeks ago

You want the spinning card to be hidden @MAVRICK-1 ?

MAVRICK-1 commented 3 weeks ago

https://youtu.be/rWQeqH526KA?si=UOgzMQNaHl7zbi12 @Ojas-Arora shoudn't it be something like ?

Ojas-Arora commented 3 weeks ago

Ok I will make like this @MAVRICK-1

Ojas-Arora commented 3 weeks ago

@MAVRICK-1 Please review the changes