MAVRICK-1 / Nest-Ondc

https://nest-ondc-arzx.vercel.app/
MIT License
24 stars 49 forks source link

Implemented My Account page #97

Open Prutha-Upadhyay opened 3 months ago

Prutha-Upadhyay commented 3 months ago

67 Implemented My Account page -->

Screenshots (if appropriate):

Screenshot 2024-06-10 231722

Types of changes

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nest-ondc ❌ Failed (Inspect) Jul 6, 2024 7:47am
nest-ondc-arzx ❌ Failed (Inspect) Jul 6, 2024 7:47am
Prutha-Upadhyay commented 3 months ago

please check this!

MAVRICK-1 commented 3 months ago

@Prutha-Upadhyay MyAccount page is not created .

Prutha-Upadhyay commented 3 months ago

@MAVRICK-1,Now please check this!

Sahilll15 commented 3 months ago

it has conflicts in yarn.lock file please solve that @Prutha-Upadhyay

Prutha-Upadhyay commented 3 months ago

@Sahilll15 Can you help me out where is the conflict? How to solve it?

akbatra567 commented 3 months ago

@Sahilll15 Can you help me out where is the conflict? How to solve it?

@Prutha-Upadhyay, I can help if you're still looking for help in resolving conflict.

Prutha-Upadhyay commented 3 months ago

@akbatra567 Yes please, I tried it so many times but I am enable to find where is the exact problem and how to solve it?

akbatra567 commented 3 months ago

@akbatra567 Yes please, I tried it so many times but I am enable to find where is the exact problem and how to solve it?

@Prutha-Upadhyay, You have to take a pull of recent changes in your current branch into your branch. One such way is

  1. Add the original repo as an upstream remote

-> using ssh

git remote add upstream git@github.com:MAVRICK-1/Nest-Ondc.git

-> using https

git remote add upstream https://github.com/MAVRICK-1/Nest-Ondc.git
  1. Take pull
git pull upstream dev

Note: This might give a warning to use Fast-forward or Rebase

To use Rebase:

git pull --rebase upstream dev

Reference commands:

To Continue rebase: git rebase --continue

To abort rebase git rebase --abort

Prutha-Upadhyay commented 3 months ago

@akbatra567 Thank you for your help!!👍

Prutha-Upadhyay commented 3 months ago

Resolved that and now My Account Page

https://github.com/MAVRICK-1/Nest-Ondc/assets/120392487/613bbf01-0c87-4a29-bba3-887b488380c4

and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

akbatra567 commented 3 months ago

Resolved that and now My Account Page

Screen.Recording.2024-07-01.194442.mp4 and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

Looks fine, Just a look query. Have you added any new packages or upgraded any package ? @Prutha-Upadhyay

Prutha-Upadhyay commented 3 months ago

Resolved that and now My Account Page Screen.Recording.2024-07-01.194442.mp4 and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

Looks fine, Just a look query. Have you added any new packages or upgraded any package ? @Prutha-Upadhyay

No, I did not!

akbatra567 commented 3 months ago

Resolved that and now My Account Page Screen.Recording.2024-07-01.194442.mp4 and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

Looks fine, Just a look query. Have you added any new packages or upgraded any package ? @Prutha-Upadhyay

No, I did not!

Then, could you remove package-lock.json and yarn.lock

Prutha-Upadhyay commented 3 months ago

Resolved that and now My Account Page Screen.Recording.2024-07-01.194442.mp4 and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

Looks fine, Just a look query. Have you added any new packages or upgraded any package ? @Prutha-Upadhyay

No, I did not!

Then, could you remove package-lock.json and yarn.lock

But I have added one dependency fsevents in yarn file, so is it safe to remove yarn file?

akbatra567 commented 2 months ago

Resolved that and now My Account Page Screen.Recording.2024-07-01.194442.mp4 and also change Email format because it is replacing . to _ and stored wrong email address.....! @akbatra567 please kindly review this!!

Looks fine, Just a look query. Have you added any new packages or upgraded any package ? @Prutha-Upadhyay

No, I did not!

Then, could you remove package-lock.json and yarn.lock

But I have added one dependency fsevents in yarn file, so is it safe to remove yarn file?

If you've added a new package it should also be in package.json file, just verify if you are upgrading the version of any package and mention the same in the PR description.

Prutha-Upadhyay commented 2 months ago

Okay, I am removing both files!

akbatra567 commented 2 months ago

@MAVRICK-1, Would need some help here to see the logs on vercel, as I can't see on my end. Need to identify the cause of checks falling.