MAVRICK-1 / e-commerce_website

MIT License
73 stars 116 forks source link

Bug: Email type of Newsletter is not defined and no toast message after subscribe #185

Open Aniket-2504 opened 5 months ago

Aniket-2504 commented 5 months ago

Dear @MAVRICK-1 ,

Issue

The Issue is -

1. Newsletter Subscribe Input:

The input field for the newsletter subscription is not defined as an email input. This allows users to enter invalid email addresses, which can lead to data quality issues.

2. Missing Toast Message:

After subscribing to the newsletter, the toast message confirming the subscription does not appear. This can result in user confusion as there is no immediate feedback indicating the success of their action.

Screenshot -

I have attached a video demonstrating both issues for your reference.-

https://github.com/MAVRICK-1/e-commerce_website/assets/145179532/1eb4dbae-9a34-45ec-9098-410aa0318447

Could you please assign this task to me? I am confident that I can implement the necessary fixes to improve the user experience on the website.

I look forward to your response.

github-actions[bot] commented 5 months ago

Hi there!

Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

Please note that this is the project owner, @MAVRICK-1. I won't be available for 3-4 days and will reply to every PR after May 22. Thank you for your cooperation.

MAVRICK-1 commented 5 months ago

@Aniket-2504 i haven't added the functionality yet .

Aniket-2504 commented 5 months ago

If you never mind can I add this functionality, I want to work on this issue,

MAVRICK-1 commented 5 months ago

@Aniket-2504 okay go ahead , i will give you level after seeing ur pr

Aniket-2504 commented 5 months ago

Sure bro I will give my best