[Feature Request]: About us Not able to scroll bug #447

MAVRICK-1 / e-commerce_website

MIT License

74 stars 116 forks source link

[Feature Request]: About us Not able to scroll bug #447 #459

Closed nishant0708 closed 3 months ago

nishant0708 commented 3 months ago

-fixed about us not able to scroll issue

[Feature Request]: About us Not able to scroll bug #447

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

https://github.com/MAVRICK-1/e-commerce_website/assets/101548649/5443373b-92d8-4020-ba7c-15970b388f59

Types of changes

[ y] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ y] My code follows the code style of this project.
[y] My change requires a change to the documentation.
[ y] I have updated the documentation accordingly.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nestondc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2024 11:33pm
nestondcshop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2024 11:33pm

nishant0708 commented 3 months ago

hen @dinxsh can you review this pr

dinxsh commented 3 months ago

2 word pr? really? @nishant0708

nishant0708 commented 3 months ago

2 word pr? really? @nishant0708

It just get solved in that only 😂 bro you could have merged it and not assigned any labels to it. Sorry for the trouble mam @dinxsh

dinxsh commented 3 months ago

closed since the about us scroll works for me. no worries though there are always other issues @nishant0708

nishant0708 commented 3 months ago

hey @dinxsh see in about us there is a issue whenever the state of component changes it just scroll backs to top . See checkit go to about scroll down and hover on any card it will scroll you to top to fix that just in useeffect( ( ) , [ ] ) just add this array in useeffect it will be fine . its just bugging me so fix it from you end

dinxsh commented 3 months ago

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

nishant0708 commented 3 months ago

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

It is happening in local host

dinxsh commented 3 months ago

oh, does it happen in localhost or live? it doesn't occur with me on the live link, if so you I can re-open and deploy this pull request

It is happening in local host

do pull the new merged changes to fix then