FacebookUserXMLParser improvements

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Put trace statements inside a the if bodies in FacebookUserXMLParser.as
2. Do a GetInfo call requesting just first_name

What is the expected output? What do you see instead?

The code should only get through the if (first_name) statement, but you'll
see that all those if conditions return true, we need to check against
undefined instead.

What version of the product are you using? On what operating system?

Rev 287, Flex 3.3

Please provide any additional information below.

This patch also removes .. searching and use faster, more explicit
userProps.ns::foo so it needs double checking to make sure the parsing is
correct, but I think I got it. Using ".." is dangerous as it could pull a
field from anywhere.

Original issue reported on code.google.com by rob%elec...@gtempaccount.com on 2 Apr 2009 at 9:21

Attachments:

• FacebookUserXMLParser.as.patch

[GoogleCodeExporter]

Re-rolled patch. To test, put trace() inside each if and you'll see they always
result to true, hence the undefined checks. Also, using E4X ".." is dangerous 
and
slower than using "." and this patch covers that as well.

Original comment by rob%elec...@gtempaccount.com on 28 Apr 2009 at 2:55

Attachments:

• FacebookUserXMLParser.as.patch

[GoogleCodeExporter]

This has been fixed, so no patch needed.

Original comment by rob%elec...@gtempaccount.com on 31 Aug 2009 at 10:38

[GoogleCodeExporter]

New release based of Facebook's Graph API is coming soon.  SDK which this issue 
depends on is no longer supported by Facebook.

Original comment by alan...@gmail.com on 29 Sep 2010 at 7:49

• Changed state: WontFix