search

MAleemH / Math-Magicians

Math Magicians is a website for all fans of mathematics. It is a Single Page App (SPA) that allows users to make simple calculations and read a random math-related quote.
MIT License
6 stars 0 forks source link

Math Magicians: refactor with hooks #5

Open MAleemH opened 1 year ago

MAleemH commented 1 year ago

I have already used functional components instead of class components. So, I think there is no need for refactoring.

https://github.com/MAleemH/Math-Magicians/blob/779168bd1c0503bdb288195782b317dd3e766bfc/src/components/calculator.js#L1-L17

TadesseDev commented 1 year ago

Hi @MAleemH

I'm Tadesse Alemayehu your reviewer for this PR. :hand:

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 giphy (1)

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.