display groupBMC - Githubissues

MBB-team / VBA-toolbox

The VBA toolbox

GNU General Public License v3.0

130 stars 67 forks source link

display groupBMC #24

Open lionel-rigoux opened 7 years ago

lionel-rigoux commented 7 years ago

VBA_displayGroupBMC shows the exceedance probability of all models in the lower right panel. Shouldn't it rather display the protected exceedance probability, when available?

jdaunize commented 7 years ago

Good point. In brief:

Pros: 1) consistency with our previous work 2) ?
Cons: 1) it's not always available (cf. family inference), which means that the output will not always be the same.
2) it does not leave the users the choice of using which metric they want To me this is 2-1 for no :) J.

lionel-rigoux commented 7 years ago

Well, we could show both.

- people will see that two stats are available for BMC, but only one for family
- people can choose which one they prefer
- if we keep the xp as it is and use a new color for the pxp 
    - we provide continuity, so people don’t get confused
    - we attract attention to the latest work, insuring consistency with puplications

jdaunize commented 7 years ago

OK for displaying both (with 2 colours and a clear legend) :) J.