search

MBB-team / VBA-toolbox

The VBA toolbox
GNU General Public License v3.0
130 stars 67 forks source link

stat missing in the function description #47

Closed NicolasClairis closed 7 years ago

lionel-rigoux commented 7 years ago

Hey,

Thanks for correcting the documentation! I spotted some additional typos. I don't know this function, could you update your patch before I merge it to the master?

Cheers

lionel-rigoux commented 7 years ago

Is this still active? It shouldn’t be too long to add a couple of lines of documentation ;)

lionel-rigoux commented 7 years ago

Note that answering to an email initiated by a github issue/pull request is automatically added to the issue thread and forwarded to all the contributors of the repo. You didn’t send your last email to my personal gmail address, you contributed to the github discussion (as you can see here: https://github.com/MBB-team/VBA-toolbox/pull/47 https://github.com/MBB-team/VBA-toolbox/pull/47) and that was broadcasted to other VBA contributors including Jean. Given his (understandably) laconic and surprised response, I am not sure he will take care of this. And pointing fingers won’t make things go forward...

I suggest you talk to each others and decide who’s pushing a complete patch. If this pull request is not updated in the upcoming week, I will just close the pull request and flag the missing doc in a separate issue.