MBB-team / VBA-toolbox

The VBA toolbox
GNU General Public License v3.0
129 stars 67 forks source link

sign of the log-likelihood of the VBA_groupBMC function #89

Closed XiaoyuZeng closed 1 year ago

XiaoyuZeng commented 1 year ago

Dear all,

I have a problem concerning the input of the VBAgroupBMC function.

the note in this function states that “L: Kxn array of log-model evidences”.

therefore, it seems that I should just put the raw glm.LogLikelihood (from fitglm in matlab). But I was instructed by a friend that I should reverse the sign of the glm.LogLikelihood before putting them in the VBAgroupBMC function. She linked to a discussion about reversing the sign of AIC (https://muut.com/i/vba-toolbox/questions:vba-groupbmc-script).

but the corresponding BMC result was inconsistent with the result that just compared group-sum BIC when I submitted the reversed glm.LogLikelihood. actually, these two results were in the opposite direction. thus I began to reflect that maybe I shouldn't reverse the glm.LogLikelihood.

my questions is, which one should I put into the VBA_groupBMC function, the raw glm.LogLikelihood or the reversed one?

Best,

Xiaoyu

XiaoyuZeng commented 1 year ago

Lionel's reply on the VBA forum (http://mbb-team.github.io/VBA-toolbox/forum/) perfectly solved my problem. I guess this issue can be closed now.