search

MBRO95 / PortableCellNetwork

Utilize a Raspberry Pi and a Nuand BladeRF to generate your own portable local cell network
https://mbro95.github.io/PortableCellNetwork/
388 stars 94 forks source link

Modernize Python 2 code to get ready for Python 3 #2

Closed cclauss closed 5 years ago

cclauss commented 6 years ago

Make the minimal, safe changes required to convert the repo's code to be syntax compatible with both Python 2 and Python 3. There might be other work required to complete the port to Python 3 but this is a minimal, safe first step.

MBRO95 commented 6 years ago

Hi there, I appreciate the desire to modernize this code. Unfortunately, throughout the development of this script and tireless testing, we narrowed this specific version of PySIM down that actually functioned. Yes, there are newer versions of PySIM (they may even be modernized to your liking), but they were incompatible with either the drivers we needed or the software we had to integrate with (YateBTS; which also required a specific version to run in our context). I will approve this request if you’d like to take it upon yourself to fully convert to Python3 support and test the entire implementation to ensure that it works. Otherwise, I’m going to have to keep this as is as the versions of software in this script were selected for verified complete functionality.

cclauss commented 6 years ago

These changes will not break Python 2 compatibility. The are compatible with BOTH Python 2 AND Python 3. If you accept this PR, your code should continue to work as before.

MBRO95 commented 6 years ago

I don’t have the time currently to test this on my own. If you deploy this code and your changes and test it and provide the same output/functionality as before I will merge. Until then, I’m not going to, current-state works and that’s the point.