search

MBU-Team / OpenMBU

A reverse engineered version of Marble Blast Ultra from Xbox 360
156 stars 20 forks source link

[REQUEST] Marble reflections should update at higher frame rates #220

Open McMasterGold opened 6 months ago

McMasterGold commented 6 months ago

Is there an existing issue for this?

Version

Beta 1.17

OS

Windows 11

Description

The real-time marble reflections update at a distinctly lower frame rate than the native one, and the problem becomes more severe when playing at lower frame rates. For example I am playing at 60 FPS, and it looks like the reflections are updating at 10 FPS. A tearing artifact can also be observed in the reflection.

The last build to not exhibit this issue was 1.14, while all builds from 1.15 and newer have it.

https://github.com/MBU-Team/OpenMBU/assets/4408387/e82d1e01-050c-45e3-a9ac-9daa220c63bd

Log File

No response

Steps to reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Reproduction frequency

No response

Additional Information

No response

RandomityGuy commented 6 months ago

This is an intentional decision to improve framerate, instead of updating all the faces at once, only two of them are updated each frame. See: https://github.com/MBU-Team/OpenMBU/blob/c0d8552d9096408b52c47726d9e93b3283bc147f/engine/source/gfx/D3D9/gfxD3D9Cubemap.cpp#L29 You can bring back the old behavior by commenting this line and compiling it https://github.com/MBU-Team/OpenMBU/blob/c0d8552d9096408b52c47726d9e93b3283bc147f/engine/source/core/torqueConfig.h#L126

McMasterGold commented 6 months ago

Appreciate the response! Sadly I have very little experience with compiling builds (and have mostly failed in the past) so I'm not quite sure how I could do this. Is there any chance that it could be added as a graphics setting in the future?

RandomityGuy commented 6 months ago

Yes, that is the plan.