search

MBoustani / GISCube

Web Based GIS Application
Apache License 2.0
44 stars 11 forks source link

Maintain Vagrantfile and other configuration files in the repository not ZIP file #57

Open wenzeslaus opened 9 years ago

wenzeslaus commented 9 years ago

I think that Vagrantfile and all the other files related to test configuration should be maintained in the repository as text files, not inside a ZIP file. In this way, they can be properly versioned and one could view them online. Subdirectory like vagranttest looks like a reasonable choice but I'm not sure what is the common practice. Installation can use source code and perhaps VM can use the local code then.

MBoustani commented 9 years ago

Vagrant.zip folder contains vagrantfile and scripts which contains scripts of installing all the dependencies. I like the idea of having them not in folder to properly versioned. In next version I will remove vagrant.zip and have them as separate files.

Thanks for great feedbacks.

wenzeslaus commented 9 years ago

You welcome. Fill the tickets, this I can do now.

Another advantage of using repository directly is that you will avoid having .DS_Store files in the ZIP file which causes:

ERROR 4: `/home/vagrant/GISCube/giscube_app/static/uploaded_files/.DS_Store' not recognised as a supported file format.

BTW, there is still one in the source code:

https://github.com/MBoustani/GISCube/blob/master/giscube_app/.DS_Store