MBulli / SmartCommandlineArgs

A Visual Studio Extension which aims to provide a better UI to manage your command line arguments
GNU General Public License v2.0
99 stars 35 forks source link

Add Custom JSON Root Path Setting (vs2022) #145

Closed orbikm closed 1 year ago

orbikm commented 1 year ago

This feature implements behavior for allowing a user to specify a custom root path for all JSON settings for each project. This works by allowing the user to specify the Root path, and the Solution name and Project names are added to the path.

This allows for saving modified Command Line arguments in a Source Control solution, while having an ephemeral Visual Studio project (such as the case when the VS projects are generated by a build system). Due to this, this resolves issue #115

A description of how we would plan to use this in practice would be something like:

  1. Have our build system generate a SolutionName.ArgsCfg.json that includes an entry for the Custom JSON Root, which is known by the build system
  2. The Custom Json Root folder will be checked into source control, allowing development teams to add useful sets of command line arguments. These changes, since they're directly pointing from Extension to the custom path, will allow devs to save and commit JSON modifications

NOTE: This is based upon the vs2022 branch, as that was the only version of Visual Studio I had installed at the moment, so I could test with it. I wanted to ask the author / maintainers if they would prefer that I rebase this change on top of main, I can do that. I wasn't sure if vs2022 branch was close to being merged or not (given that the extension is published to the Marketplace with a 2022 version).

orbikm commented 1 year ago

Ok, I reverted what I believe was the result of a bad merge / rebase. The PR is now in a functional state, ready for review.

Irame commented 1 year ago

Hi and thanks for the contribution. It would be great if you could rebase it onto master. I can test and merge it more easily there.

orbikm commented 1 year ago

I just created #146 which is this same PR but rebased onto master. Feel free to close this Pull Request in lieu of the other.