MC-Machinations / PaperTweaks

A better-performance replacement for the popular VanillaTweaks datapack collection.
GNU General Public License v3.0
138 stars 12 forks source link

Enhancement Elytra/Chestplates to carry over Custom Enchantments #39

Open EchocallingEarth opened 2 years ago

EchocallingEarth commented 2 years ago

The ability to carry over custom enchantments.

Meaning that if a chestplate is enchanted with 'ExampleX' it will carry over to the Elytra when combined.

Currently, only vanilla enchantment carry over and that makes using some custom enchantments pointless and rather frustrating to players who discover their hard-earned custom enchantment is broken when combining Elytra and chestplates.

Adding this feature would make the use of this function highly sought after on any servers using custom enchanting plugins like AdvancedEnchants, Crazy Enchantments, and many more

I can try to explain better what I mean however I think the concept is clear. Or at least I hope it is.

Thanks for all you hard work and I really hope this can be implemented. Anything I can do to help make this possible feel free to reach out to me here or on Discord EchocallingEarth#0001

Machine-Maker commented 2 years ago

Sounds like good idea, but each of these enchantment plugins go about adding enchants in a different way, so I can't do all of them. What are the most used ones?

EchocallingEarth commented 2 years ago

The most common is AdvancedEnchantments.

AdvancedEnchantments has the most actively involved Dev and community from what I have found.

There are others however I have checked a few and in at least 1 case the plugin is not updated. In another case, the dev warns about using on a production server and the final one is much much smaller and does not seem to have a large following.

Now with all that said I would recommend AdvancedEnchantments, I have tested and use others but this is, in my opinion, the best.

If there is anything I can do to further assist do not hesitate to ask.

ElFrod0 commented 1 year ago

@Machine-Maker I highly recommend copying over NBT tags. Many plugins do not even register enchantments.