MC-Machinations / PaperTweaks

A better-performance replacement for the popular VanillaTweaks datapack collection.
GNU General Public License v3.0
141 stars 13 forks source link

Could not pass event PlayerBedLeaveEvent OR PlayerQuitEvent to VanillaTweaks v0.2.0-SNAPSHOT #53

Closed SleepyCatten closed 2 years ago

SleepyCatten commented 2 years ago

Hi,

I believe this is an issue with the MultiplayerSleep component.

I've pasted the current log of the server here, showing both types of error: https://gist.github.com/SleepyCatten/123c580aaf82e47787ad97fb55ebb0bc

Please let me know if you need further details.

Machine-Maker commented 2 years ago

I’ll look at it later today, do you have a set of instructions to reliably reproduce the error appearing in the log? Also, please post your multiplayer sleep config file.

SleepyCatten commented 2 years ago

Thanks for the reply.

To reproduce:

  1. Run a Paper 144 server with the Paper Tweaks plugin with MultiplayerSleep enabled.
  2. Use to bed to sleep.

That was triggering it every time.

'# Worlds to count player's from included-worlds:

I ended up working around this by disabling it and setting the gamerule for 1.18 playersSleepingPercentage to 0

Machine-Maker commented 2 years ago

I can't replicate it that easily, or at all rather. What plugins do you have installed? I feel like there might be a conflict somewhere.

Machine-Maker commented 2 years ago

Also, can you quickly download the the zip from here, under the Artifacts header and try out that build? I think I maybe fixed an issue, but I'm still not 100% on what's going on.

SleepyCatten commented 2 years ago

Hi. Just tried that version and the error message no longer appears. Unless someone else finds otherwise, it looks like you fixed it. Sorry for the slow response, by the by!

Machine-Maker commented 2 years ago

And the functionality works correctly? All as expected?

SleepyCatten commented 2 years ago

Worked fine. One player allowed the server to sleep without any issue.