MC-Mods-Pete / Contagion

Contagion Mod
MIT License
0 stars 0 forks source link

[COMPATIBILITY] with Penomior. #7

Closed makumaku1974 closed 1 month ago

makumaku1974 commented 1 month ago

I have to bump this to you because the Evasion skill from Penomior still infects the player regardless.

makumaku1974 commented 1 month ago

https://github.com/MrSypz/Penomior/issues/6#issuecomment-2229951991

MC-Mods-Pete commented 1 month ago

thanks for pointing that out, I will have a look

MrSypz commented 1 month ago

you don't need to do it anymore, I already inject my method before callback event happen 👍I forgot fabric have this callback too 🤣

makumaku1974 commented 1 month ago

you don't need to do it anymore, I already inject my method before callback event happen 👍I forgot fabric have this callback too 🤣

let me check again. okay it's fixed, No need to fix it Pete.

MC-Mods-Pete commented 1 month ago

Thanks for the info, I already did a rework of my stuff ;) Because there is some truth to Contagion being a bit op at times.

In my rework I now inject my stuff into the tryAttack methods, so I can check if the player was actually hurt :)