MC-U-Team / Music-Player

With this mod you can listen to music and manage your playlist without using external programs
https://u-team.info/mods/musicplayer
Apache License 2.0
57 stars 20 forks source link

[1.18.2] Local file options non-functional on Steam Deck #1102

Open tlsctf2 opened 2 months ago

tlsctf2 commented 2 months ago

Bug description and reproduction steps

Playing through Prism Launcher on Steam Deck, the "Load file" and "Load folder" buttons simply do nothing when pressed. The log's only information given is as follows:

sh: line 1: xprop: command not found

No further information is given. To me, this seems like it may be an issue with Windows-Linux compatibility. Is there anything I can do to add local files to a playlist without the in-game GUI?

Log files and Screenshots

sh: line 1: xprop: command not found

Used minecraft version

1.18.x

Used forge or fabric version

40.2.21

Used mod version

2.3.4.264

HyCraftHD commented 2 months ago

Hi, seems like tinyfd is not working there. This is more of a vanilla bug as this library comes from vanilla. However, you should be able to add a path from a file to the URL bar to add local files.

tlsctf2 commented 2 months ago

No dice, just get a "No matches found" error. I saw that an update was released while I wasn't watching, so I'll see if that update does anything before I go on.

tlsctf2 commented 2 months ago

Update didn't help on either front. Thought this would be the case, since I didn't see anything about it in the patch notes, but it's good to have confirmation, at least.

This is probably a Linux-specific thing. Here's roughly how the file path looks when I hit "Copy location" on Steam Deck:

/run/media/deck/0123-4567/(filename)

The 0123-4567 in this case is an external SD card. I haven't tried this with a file actually on the Steam Deck yet, but since there's no drive letter at the beginning of these links, I doubt it would do anything. May do some trial and error to see if anything tricks this into working.

HyCraftHD commented 2 months ago

On windows and other linux systems it works fine like this: image

Unfortunately I don't have a Steam deck to test

tlsctf2 commented 2 months ago

This is what I was doing; I assume that, because there's no drive letter at the start (e.g. C:) the mod tries to read it as a web link. I haven't found a way to circumvent this on my end, sadly, so I guess I'll have to make do with online stuff for now.

HyCraftHD commented 2 months ago

You could try to prefix your uri with the file protocol: file:///run/media/deck/0123-4567/(filename)

tlsctf2 commented 2 months ago

No luck there either, I'm afraid. I'm not even sure how this could be reliably tested without you having a Linux system to do it with, so I'm not too pressed about it. Thank you for trying to help me work around it, though!