search

MCBTay / XLGearModifier

A mod to add custom meshes into the gear menu of SkaterXL, allowing the ability to custom texture these meshes through the Gear folder.
8 stars 6 forks source link

Add CheckBox for XLGMSkaterMetadata to Allow Male/Female Clothing #111

Closed MCBTay closed 2 years ago

redgouf commented 2 years ago

Had a few issue that came out of testing today.

  1. When we have this enabled, the Male Skater, Female Skater, and Custom Skater all get BOTH Male and Female menus. If the Male Clothing option is selected in Editor, the Female Custom Meshes menu will appear and be empty. Vice Versa, if Female is selected in editor.

https://user-images.githubusercontent.com/13354972/162232305-8bed6f41-ea6b-408a-b397-6863d8376942.mp4

  1. The Default and "Custom" categories will show ALL of the gear of that category (vanilla AND custom meshes/textures) - this makes the menu lag hard when switching categories.
  2. When having Custom Skins setup for multiple different Custom Skaters, the "Custom Skin" menu is not pulling the correct textures for the Skater selected.
    1. Similarly, the "Skin" and "Custom Skin" menu options for Male and Female skater are also replaced, making it impossible to change skin from the default.
  3. Eyes menu is showing for Custom Skater, which should be hidden.

https://www.youtube.com/watch?v=myK2DCgjv0Y

https://user-images.githubusercontent.com/13354972/162248538-f46a533a-3bbd-49c1-9131-c99d94bdd930.mp4

MCBTay commented 2 years ago

Commenting here for my own sanity as I keep rechecking the same things.

  1. Skaters getting both male/female mesh menus
    1. This has been resolved
  2. All gear showing
    1. Seems like the isCustom flag is being totally ignored. I had removed some code (not sure if it was a part of this PR or not) that was actively filtering custom objects out of standard lists, but at least initially that seems like a bandaid. Haven't dug into this yet.
  3. Skin/custom skin issues
    1. Still researching, some of this is due to the alias to malehead we found earlier I think, but there's definitely more going on than that.
  4. Eyes showing for skaters other than male/female
    1. This has been resolved
MCBTay commented 2 years ago

After further investigation, the 3rd point in the list above is probably more likely due to me removing some code that was actively attempting to filter out custom meshes from these tabs. I was thinking it was unnecessary but that was the wrong call.

MCBTay commented 2 years ago

Believe 2 in the list above has been resolved. Along with #23, actually.

redgouf commented 2 years ago

Works good for Males flag. I will need to test with Female flag for clothing.

redgouf commented 2 years ago

I added a new female skater (with clothing) and things are looking all good.

Screenshot_2