search

MCBTay / XLGearModifier

A mod to add custom meshes into the gear menu of SkaterXL, allowing the ability to custom texture these meshes through the Gear folder.
8 stars 6 forks source link

Selecting Some Textures Will End Up with Wrong JSON #164

Open MCBTay opened 2 years ago

MCBTay commented 2 years ago

While tracking down #140, I noticed that on some of the meshes I was equipping would have incorrect JSON.

For example, the root cause of #140 ended up revolving around isCustom being true/false for a particular item. The mod would incorrectly have isCustom as false upon initial selection of the item. But if you selected another item, the customization file would get rewritten properly and isCustom would suddenly be true. When isCustom stayed false, everything worked fine. But as soon as it flipped to true, things were broken. (This issue was resolved as a part of the resolution of #140).

However, we probably should ensure we're writing the correct values to the JSON to prevent weirdness like this in the future. At least for the immediate, I don't think it's causing us a ton of headache.

redgouf commented 2 years ago

I haven't seen this cause any issues on the front-end, but I'm sure if I were to take a look at the json randomly, it would prove otherwise.

MCBTay commented 2 years ago

Was going to try and luck into this but am struggling to reproduce it. Looking back at our conversation then (around June 16th in Discord), it appears I was able to easily reproduce it with mshirtbuttonlongopenshirt.