search

MCCTeam / Minecraft-Console-Client

Lightweight console for Minecraft chat and automated scripts
https://mccteam.github.io
Other
1.67k stars 402 forks source link

Replay Mod File Crashing #2205

Open BridgingDragon opened 2 years ago

BridgingDragon commented 2 years ago

So I joined a server with Console Client (1.19.2) and then saved the replay file. I then launched 1.19.2 with fabric & replay mod (for 1.19.2) and put the replay into my replays folder. It showed up in the list of replays, as expected, but then when I tried to open the replay it simply just spams my logs with a TON of errors and then never loads (its stuck on the Minecraft dirt block screen) I have attached my logs and also have screenshots of my mods folder and etc.

Logs: https://paste.ee/p/yQ8pm Mods folder and etc:

(The screenshot below says the replay mod is 1.19.1 but its the same for 1.19.2 and 1.19.1) image image And also here is the replay file if that helps at all: https://ucarecdn.com/408c960a-3269-444f-bb7e-ddf005539456/

I've tried loading multiple files from Console Client and every time it crashes, but I can load files that I recorded from normal Minecraft.

ghost commented 2 years ago

thats linux fault. install windows.

BridgingDragon commented 2 years ago

It is not linux's fault my friend on windows tried it and it did the same thing.

ghost commented 2 years ago

delete linux

ReinforceZwei commented 2 years ago

The implementation of the Replay Mod feature is unofficial and haven't been updated since it was made. Unfortunately I don't have time to fix it. You will have to wait for other contributors to take a look at the Replay Mod feature. Therefore, I would recommend you to stick with the official Replay Mod.

milutinke commented 2 years ago

delete linux

How about stop shilling for corporate stuff, he asked for a solution not for unnecessary comments.

milutinke commented 2 years ago

Whoever would like to fix this would have to compare the following files and see what the problem is: https://github.com/MCCTeam/Minecraft-Console-Client/blob/aec38d83c767cf4fff64a6ad2b7dfcebb076e6ab/MinecraftClient/Protocol/ReplayHandler.cs#L238

https://github.com/ReplayMod/ReplayMod/blob/09baa26a1a6c77a2f66057e932f55de0df08466c/src/main/java/com/replaymod/recording/packet/PacketListener.java#L170

TheSnoozer commented 2 years ago

The replay mod file will store the packetIDs (https://github.com/MCCTeam/Minecraft-Console-Client/issues/1007#issuecomment-677860079) so I don't think it's an issue within dumping the replay file. I would rather suspect that there is a ID for a packet incorrectly encoded between the versions. Haven't looked at the code though :dango:

milutinke commented 2 years ago

@BridgingDragon Can you upload the replay file again? The current one has expired.

milutinke commented 2 years ago

The replay mod file will store the packetIDs (#1007 (comment)) so I don't think it's an issue within dumping the replay file. I would rather suspect that there is a ID for a packet incorrectly encoded between the versions. Haven't looked at the code though dango

That could be the case actually. @BridgingDragon Have you recorded the replay on the same version of the game as the replay mod one?