[BUG] AutoFishing Retacting

Pedro9700 commented 5 months ago

Prerequisites

[X] I made sure I am running the latest development build
[X] I tried to look for similar issues before opening a new one
[X] I have set debugmessages=true in config to diagnose my issue
[X] I have redacted session tokens and passwords before attaching screenshots

Minecraft Version

1.19.4

Console Client Version

Latest

Expected Behavior

Automatically Fishing

Actual Behavior

its casting and retracting just a second after

Steps to Reproduce the bug

Laucnh console client with auto fish enable
it just casts and retracts a second after with (count: x)

Attach screenshot here (If applicable)

No response

Anythings that could help diagnosing the bug

[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:15: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,45 Y:109,36 Z:2417,47  Dx=-5,552734 Dy=2,741211 Dz=0,020264
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,20 Z:2417,47  Dx=-0,322510 Dy=0,161133 Dz=0,001465
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,23 Z:2417,47  Dx=0,000000 Dy=0,973389 Dz=0,000000
[MCC] [AutoFishing] 11:47:16: Retract the fishing rod. (Count: 1)
[MCC] [AutoFishing] FishingBobber despawn at X:-2391,12 Y:106,73 Z:2417,47
[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:17: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,41 Y:109,27 Z:2417,48  Dx=-5,592041 Dy=2,646240 Dz=0,011719
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,07 Z:2417,48  Dx=-0,283203 Dy=0,196045 Dz=0,000732
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,10 Z:2417,48  Dx=0,000000 Dy=0,973633 Dz=0,000000
[MCC] [AutoFishing] 11:47:18: Retract the fishing rod. (Count: 2)
[MCC] [AutoFishing] FishingBobber despawn at X:-2391,12 Y:106,60 Z:2417,48
[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:19: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,42 Y:109,31 Z:2417,46  Dx=-5,581055 Dy=2,686279 Dz=0,027832
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,12 Z:2417,46  Dx=-0,294189 Dy=0,185791 Dz=0,001709
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,15 Z:2417,46  Dx=0,000000 Dy=0,973633 Dz=0,000000
[MCC] [AutoFishing] 11:47:20: Retract the fishing rod. (Count: 3)
[MCC] [AutoFishing] FishingBobber despawn at X:-2391,12 Y:106,65 Z:2417,46
[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:21: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,56 Y:109,32 Z:2417,57  Dx=-5,439697 Dy=2,701416 Dz=-0,078857
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,24 Z:2417,58  Dx=-0,435547 Dy=0,082764 Dz=-0,006348
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,40 Z:2417,58  Dx=0,000000 Dy=0,840820 Dz=0,000000
[MCC] [AutoFishing] 11:47:21: Retract the fishing rod. (Count: 4)
[MCC] [AutoFishing] FishingBobber despawn at X:-2391,12 Y:106,99 Z:2417,58
[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:22: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,47 Y:109,29 Z:2417,54  Dx=-5,534424 Dy=2,665283 Dz=-0,043945
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,13 Z:2417,54  Dx=-0,340820 Dy=0,153564 Dz=-0,003418
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,16 Z:2417,54  Dx=0,000000 Dy=0,973633 Dz=0,000000
[MCC] [AutoFishing] 11:47:23: Retract the fishing rod. (Count: 5)
[MCC] [AutoFishing] FishingBobber despawn at X:-2391,12 Y:106,66 Z:2417,54
[MCC] [AutoFishing] FishingBobber spawn at X:-2397,00 Y:106,62 Z:2417,49, distance = 1,65
[MCC] [AutoFishing] 11:47:24: Casting successfully.
[MCC] [AutoFishing] FishingBobber X:-2397,00 Y:106,62 Z:2417,49  Dx=0,000000 Dy=0,000000 Dz=0,000000
[MCC] [AutoFishing] FishingBobber X:-2391,46 Y:109,28 Z:2417,49  Dx=-5,542480 Dy=2,659912 Dz=0,003174
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:109,12 Z:2417,49  Dx=-0,332764 Dy=0,160156 Dz=0,000244
[MCC] [AutoFishing] FishingBobber X:-2391,12 Y:108,15 Z:2417,49  Dx=0,000000 Dy=0,973389 Dz=0,000000
[MCC] [AutoFishing] 11:47:24: Retract the fishing rod. (Count: 6)

Device

None

Operating System

None

Server Address (If applicable)

No response

Pedro9700 commented 5 months ago

With a bit of further digging, i suspect it is because the bot is fishing into a wall, and then the bobber falls into the water, but because Y movement is not considered for the sationary position, it is thinking the falling into the water as catching a fish. If there was a way to add a delay or a treshold where it has to be stationary in all directions and only after able to catch a fish would be something nice.

Pedro9700 commented 5 months ago

Confirm my previous assumption and fixed it by making it so it only starts detecting the fish bite after 2 seconds, saving the time the bobber was thrown and then comparing to that when detecting the bobber movement. Worked for me, but maybe adding a time treshold to the config could prove beneficial in some cases? This is nor particularly a bug, maybe a feature7enhancement because the bot did what it was supposed to i guess :)

MCCTeam / Minecraft-Console-Client