search

MCG-NKU / E2FGVI

Official code for "Towards An End-to-End Framework for Flow-Guided Video Inpainting" (CVPR2022)
Other
1.02k stars 99 forks source link

Error in backward BidirectionalPropagation #58

Open kudashev opened 1 year ago

kudashev commented 1 year ago

When 'backward' propagation is applied, flow_idx was forgotten to be reversed as well here:

https://github.com/MCG-NKU/E2FGVI/blob/master/model/modules/feat_prop.py#L101

Code was copied inaccurate from BasicVSR++, please refer to: https://github.com/ckkelvinchan/BasicVSR_PlusPlus/blob/master/mmedit/models/backbones/sr_backbones/basicvsr_pp.py#L180

Paper99 commented 1 year ago

Thank you for pointing out this. 👍 For reproducibility, we decided to keep the original code.