MCJack123 / craftos2

A fast, modern, and feature-filled ComputerCraft emulator written in C++.
https://www.craftos-pc.cc
Other
228 stars 26 forks source link

Android crashing again..? #372

Open Link-Jon opened 2 weeks ago

Link-Jon commented 2 weeks ago

I am unsure if its simply issue 254 again, but I myself and apparently two others are crashing on launch.

Note, this data is just using the google play store reviews, and so may or may not be fully correct. (Even my own devices are partially from memory.)

The devices that have been seen to crash on launch are: Moto G Stylus 5g 2024 // XT2419V (Android 14) --Had to double check. Thought it was 13... Actually 14. Google Pixel 8 (Android 14) Device OnePlus 9 Pro? (OxygenOS14 AKA Android 14)

However, there's also known devices where it simply works. Moto G Stylus 2020 (Android 12..?) Device OnePlus 9 Pro (OxygenOS13 AKA Android 13)

With my very very limited data, i think something CraftOS is relying on was removed between android 13 and 14. However, I myself dont know enough about the project to actually know what.

MCJack123 commented 2 weeks ago

Looks like Android 14 changed some stuff with requesting USB permissions which is causing this crash. The problem is from upstream SDL, and was fixed in https://github.com/libsdl-org/SDL/commit/5a26b26880539e4c54e8457290a8586a0a086ca8 - I'll have to merge the latest code into my project to fix this.