search

MCJack123 / sanjuuni

Converts images and videos into a format that can be displayed in ComputerCraft.
GNU General Public License v2.0
33 stars 6 forks source link

Bump C++ requirement to C++17 #19

Closed tomodachi94 closed 7 months ago

tomodachi94 commented 7 months ago

The 1.13.0 release of Poco requires a newer version of C++, specifically C++17. The configuration phase will fail to find the Poco headers with an older C++ version.

Changes to ./configure may be reproduced by running autoconf v2.72.

Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26 Relevant discussion: https://github.com/NixOS/nixpkgs/pull/283809#issuecomment-2018996543

tomodachi94 commented 7 months ago

CI failed before this PR with the same error:

  D:\a\sanjuuni\sanjuuni\src\sanjuuni.cpp(1325,37): error C2666: 'std::fpos<_Mbstatet>::operator -': overloaded functions have similar conversions [D:\a\sanjuuni\sanjuuni\sanjuuni.vcxproj]