MCLF / mclf

A Sage toolbox for computations with Models of Curves over Local Fields
GNU General Public License v2.0
7 stars 4 forks source link

fix a problem with type V points #101

Closed swewers closed 6 years ago

swewers commented 6 years ago

In some cases, the minor valuation of a point of type V was defined incorrectly.

Related to this, the function point_on_boundary in affinoid_domains would erronously raise an assertion error under some circumstances.

Both problems have been fixed, the documentation has been clarified, and some doctests have been added.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 1278


Changes Missing Coverage Covered Lines Changed/Added Lines %
mclf/berkovich/type_V_points.py 17 18 94.44%
<!-- Total: 19 20 95.0% -->
Files with Coverage Reduction New Missed Lines %
mclf/berkovich/type_V_points.py 1 80.36%
mclf/berkovich/affinoid_domain.py 1 91.09%
mclf/semistable_reduction/reduction_trees.py 4 90.02%
mclf/curves/smooth_projective_curves.py 82 75.7%
<!-- Total: 88 -->
Totals Coverage Status
Change from base Build 1261: -0.3%
Covered Lines: 2931
Relevant Lines: 3613

💛 - Coveralls