MCMi460 / 3DS-RPC

Connect your 3DS playing status to Discord!
https://3dsrpc.com/
149 stars 8 forks source link

Refactor service types #35

Closed spotlightishere closed 4 months ago

spotlightishere commented 4 months ago

This implements some changes to allow for somewhat smoother refinements in future follow-up pull requests. Instead of having hardcoded integer checks everywhere, enum values are more heavily utilized throughout the codebase.

Note: Changes related to the API (e.g. its mixed use of network service names vs. their underlying service IDs) have not been thoroughly tested.

Future areas of improvement:

spotlightishere commented 4 months ago

Going to go ahead and close this in favor of other approaches discussed within the development server. Appreciate the feedback given there!