search

MCModderAnchor / TACZ

132 stars 25 forks source link

Add gun safety fire selection mode #275

Closed stevefan1999-personal closed 1 month ago

stevefan1999-personal commented 1 month ago

As per the description in https://github.com/MCModderAnchor/TACZ/issues/274#issue-2583355671, this PR simply implements the bare minimum needed for gun safety fire selection mode, by blocking gun input when the mode is activated and produce an empty chamber click sound when the player tries to fire the weapon in safety mode.

Holster animation will be another PR at the time being, to allow discussion on whether we should reuse the sprint animation or add a new category of animation class for this. Did it anyway and looks like the result is pretty good, let's keep it as is.

Preview:

https://github.com/user-attachments/assets/2c7fdfab-accf-4ae3-a3f9-a80164875269

https://github.com/user-attachments/assets/9a8b4b44-2548-4e59-af65-7397887a1957

stevefan1999-personal commented 1 month ago

Oh wait...I noticed the desert eagle inspection animation actually turned the safety off after the end on it...and I have safety mode on as well, that's kind of contradicting but I don't think most people would notice that. So, not planning to "fix" that...

https://youtu.be/P6m4pCicizY?t=87

stevefan1999-personal commented 1 month ago

https://www.bilibili.com/video/BV1cE411M7xH?t=258.2

I'm surprised that using the empty chamber click sound for safety sound isn't that bad after all...