MCMrARM / mcpelauncher-linux

Please note this is a legacy repository, please go to: https://github.com/minecraft-linux/mcpelauncher-manifest/wiki
GNU General Public License v3.0
312 stars 46 forks source link

cmake 3.5.1 possible?? #416

Open pepa65 opened 6 years ago

pepa65 commented 6 years ago

The cmake step fails on Ubuntu 16.04 because it only has 3.5.1 -- would it be possible to make it work by modifying the CMakeLists.txt?

pepa65 commented 6 years ago

The workaround to install cmake 3.7.2-1 from Debian Stretch (not sure if this is all safe and OK, but it worked here):

wget http://ftp.us.debian.org/debian/pool/main/c/cmake/cmake_3.7.2-1_amd64.deb
wget http://ftp.us.debian.org/debian/pool/main/c/cmake/cmake-data_3.7.2-1_all.deb
wget http://ftp.us.debian.org/debian/pool/main/libj/libjsoncpp/libjsoncpp1_1.7.4-3_amd64.deb
sudo apt install libuv1
sudo dpkg -i libjsoncpp1_1.7.4-3_amd64.deb
sudo dpkg -i cmake-data_3.7.2-1_all.deb
sudo dpkg -i cmake_3.7.2-1_amd64.deb

(Do this before doing cmake.)

lukeeey commented 6 years ago

The minimum CMake version is 2.8

pepa65 commented 6 years ago

When I did cmake .. with 3.5.1 it said minimum version 3.6 and would not complete, but that was on the gplay part...

I wondered if it really needs to be 3.6, or if that could be easily adapted. So I tried changing it to 3.5, but the cmake couldn't complete.

guppy42 commented 6 years ago

Honestly this exact issue is mentioned in the wiki :|

https://github.com/MCMrARM/mcpelauncher-linux/wiki/Requirements-for-installation#ubuntu-1604---installing-cmake-371

pepa65 commented 6 years ago

That is a good source of information! Probably a good idea to have a link to the WIki on the main Readme.

guppy42 commented 6 years ago

That is a good source of information! Probably a good idea to have a link to the WIki on the main Readme.

There is a link to it on every page, including but not limited to the readme - I doubt that putting it in the readme where people would have to scroll past the first link to view it, would lead to more people clicking it. but feel free to add a pull request ;)