search

MCMrARM / revolution-irc

A modern Android IRC client. #revolutionirc on Libera.chat
GNU General Public License v3.0
555 stars 62 forks source link

Support slide gesture with gesture navigation in Android 10 #276

Open mbjurstrom opened 3 years ago

mbjurstrom commented 3 years ago

As discussed in https://github.com/MCMrARM/revolution-irc/issues/240 the new gesture navigation supported in Android 10 and newer versions are conflicting with some existing swipe actions in revolution irc.

The main one coming to mind was the "swipe from right to show the current channel members", mentioned in https://github.com/MCMrARM/revolution-irc/issues/240. That wasn't accessible at all when the user had enabled the built in gesture navigations.

The commit https://github.com/MCMrARM/revolution-irc/commit/7c2fe66161acc9506cec50420e7da7e32950b6eb added them to them to the menu, which is a good addition. In the future it will probably be good to make sure all future added options are accesible from a menu as well as gestures.

Google/Android have a page with suggestions how to ensure compatibility with the new gesture navigation in your apps https://developer.android.com/training/gestures/gesturenav

Would be great if this could be implemented as well to preserv the swipe actions in the application but @MCMrARM mentioned in https://github.com/MCMrARM/revolution-irc/issues/240 that

as I tried to implement it I ran into a problem. It's limited to 200dp, which is actually pretty dumb because I planned to have a custom back navigation gesture in newui, but yeah Google knows better.

MCMrARM commented 3 years ago

I do not think they are conflicting with anything else as as far as I am aware no other part of the app uses slide actions though, so I think this is a non-issue. As such I am renaming the issue to "Support slide gesture with gesture navigation in Android 10"