jugendhacker
commented
3 years ago I have a very similar stacktrace also with soju as bouncer
Open danshick opened 3 years ago
jugendhacker
commented
3 years ago I have a very similar stacktrace also with soju as bouncer
benoliver999
commented
2 years ago Yep same here, on soju. For me it's when I click on the server itself.
The connection remains fine and I can click on other servers. In this case it's libera.chat, and it was working fine until I joined ##Ben
Now when I click libera.chat, the app crashes.
Here's a logcat, hopefully truncated at the right point
elouin
commented
2 years ago I have the same issue/error with soju and quakenet.
0x5c
commented
2 years ago Same crash on channel load, also soju and libera. Affects some channels and some private message buffers
Problem showed up right after switching from znc to soju
I wonder there's a borked capability on the client or bouncer side
0x5c
commented
2 years ago Since clearing the (local) logs for affected networks fixes the crash until a reconnect is done, I looked at the raw log database files with an sql editor.
I tested creating a new channel on libera, which instantly crashed the client. In the log there was a single completely nulled type 8 message. Tried the same on OFTC, with the same results.
Once a buggy channel is joined, which channels will crash seems random; all buffers (server, channel, private message) could potentially crash on click.
Interestingly enough, leaving all topic-less channels in a network completely and instantly frees that network from click-crashes, without even restarting the app or clearing the logs in the settings.
0x5c
commented
2 years ago Oh hey, the soju author has made an issue about it already and it has been marked as fixed in a commit: #248 It is sadly not part of a release yet, and by extension not currently available in the stores
But considering it does not happen with other bouncers, I wonder if the root cause is soju sending spurious empty topics.
jugendhacker
commented
2 years ago But as this is fixed we should close this issue, right?
kurahaupo
commented
2 years ago But as this is fixed we should close this issue, right?
Absolutely not.
One particular (proxy) server has been fixed; that still leaves RevolutionIRC vulnerable to any other misbehaving server.
A robust program should never crash just because a program at the other end of a network connection (or pipe) is misbehaving. (That's different from telling the user "I give up because...", and then exiting; that could be a reasonable design choice in some circumstances.)
(Using the term "server" is not a mistake: a proxy or "bouncer" is simply a server and a client running back-to-back in the same program, but and the server half is all we care about here.)
benoliver999
commented
2 years ago No no I misread this too - they mean that this app has been fixed, but not yet released - not soju.
On 2022-01-10 07:40:25, Martin Kealey wrote:
But as this is fixed we should close this issue, right?
Absolutely not.
One particular (proxy) server has been fixed; that still leaves RevolutionIRC vulnerable to any other misbehaving server.
A robust program should never crash just because a program at the other end of a network connection (or pipe) is misbehaving. (That's different from telling the user "I give up because...", and then exiting; that could be a reasonable design choice in some circumstances.)
(Using the term "server" is not a mistake: a proxy or "bouncer" is simply a server and a client running back-to-back in the same program, but and the server half is all we care about here.)
-- Reply to this email directly or view it on GitHub: https://github.com/MCMrARM/revolution-irc/issues/301#issuecomment-1009005481 You are receiving this because you commented.
Message ID: @.***>
kurahaupo
commented
2 years ago @benoliver999 right you are.
To the original point, the usual process on Github is to mark the ticket as dependent on a PR; then it's automatically closed when the PR is merged. In this case commit d01efade0e1b253a4b62954a17f6358aec619342 doesn't seem to have a PR (#248 is an issue not a PR).
0x5c
commented
2 years ago There was no PR since the developer pushed the commit directly. As far as Revolution IRC is concerned, the isue reported here is a duplicate of #248, which has been fixed in d01efade. This issue here should be closed too.
On the soju side there was indeed a bug, which has now been solved in emersion/soju@7060547809be03aa3342ae47151b97c8206230fb
The crash in revolution will still happen until the app's logs for the affected networks are purged, or you use a revolution build that includes d01efade.
I have revolution connecting to my bouncer (soju) which manages my persistent connection to libra.chat. When I click on certain channels (e.g. #nix-darwin), revolution instantly crashes. Other channels work fine and other IRC clients have no issue connecting to my bouncer and these channels. I've attached logcat logs that I believe are relevant to this issue.
2021-06-16-08-46-15.txt
Please let me know if I can provide any further information.