MCMrARM / revolution-irc

A modern Android IRC client. #revolutionirc on Libera.chat
GNU General Public License v3.0
548 stars 63 forks source link

Multiline CAP support #357

Open NospamNospam opened 5 months ago

NospamNospam commented 5 months ago

The last version I see at Google Play Store, 5.2, doesn't support multiline replies to CAP LS and CAP LIST and, for example, SASL doesn't work for me if multiline CAP reply is received. Is this corrected in the latest version here? Multiline example:

userinput  : * : <-  : CAP LS 302
useroutput : * :  -> : :******** CAP * LS * :account-notify account-tag away-notify batch cap-notify chghost draft/account-registration draft/channel-rename draft/chathistory draft/event-playback draft/languages=1,en draft/message-redaction draft/multiline=max-bytes=4096,max-lines=100 draft/no-implicit-names draft/persistence draft/pre-away draft/read-marker draft/relaymsg=/ echo-message ergo.chat/nope extended-join extended-monitor invite-notify labeled-response message-tags multi-prefix sasl=PLAIN,EXTERNAL server-time setname
useroutput : * :  -> : :******** CAP * LS :standard-replies userhost-in-names znc.in/playback znc.in/self-message
userinput  : * : <-  : NICK ********
userinput  : * : <-  : USER ******** 0 * :********
userinput  : * : <-  : CAP END
useroutput : * :  -> : :******** 464 * :Password incorrect

Oneline example:

userinput  : * : <-  : CAP LS 302
useroutput : * :  -> : :******** CAP * LS :account-notify account-tag away-notify batch cap-notify chghost draft/account-registration draft/channel-rename draft/chathistory draft/event-playback draft/languages=1,en draft/multiline=max-bytes=4096,max-lines=100 draft/persistence draft/read-marker draft/relaymsg=/ echo-message ergo.chat/nope extended-join extended-monitor invite-notify labeled-response message-tags multi-prefix sasl=PLAIN,EXTERNAL server-time setname userhost-in-names znc.in/playback znc.in/self-message
userinput  : * : <-  : NICK ********
userinput  : * : <-  : USER ******** 0 * :********
userinput  : * : <-  : CAP REQ :batch cap-notify multi-prefix sasl server-time znc.in/self-message
useroutput : * :  -> : @time=******** :******** CAP * ACK :batch cap-notify multi-prefix sasl server-time znc.in/self-message
userinput  : * : <-  : AUTHENTICATE PLAIN
useroutput : * :  -> : AUTHENTICATE +
userinput  : * : <-  : AUTHENTICATE ********
accounts   : client : * : logged into account : ********
useroutput : * :  -> : @time=******** :******** 900 * * ******** :You are now logged in as ********
useroutput : * :  -> : @time=******** :******** 903 * :Authentication successful
userinput  : * : <-  : CAP END