MCPHackers / LaunchWrapper

Launch wrapper for legacy Minecraft
MIT License
21 stars 3 forks source link

(Suggestion) Use JSON patches for MultiMC instances #2

Closed NeRdTheNed closed 3 months ago

NeRdTheNed commented 1 year ago

This allows changing the Minecraft version in the instance without re-editing the component, and easier interoperability with other MultiMC features. More information about JSON patches can be found on the MultiMC wiki page about them. Here is a MultiMC instance demonstrating this.

Instructions:

This should produce an instance similar to the attached one. I also edited mmc-pack.json to set dependencyOnly to be true on the LaunchWrapper patch, which prevents disabling it (optional).

Lassebq commented 1 year ago

So, I'm not too sure, but does this issue suggest replacing MultiMC install guide with this? If so, could you please make it into a pull request? Thanks.

Lassebq commented 3 months ago

Due to my decision of not shipping versioned releases (until launchwrapper is stable) this method is now broken, as MultiMC derivatives (in my case Prism Launcher) fail with this error message:

Instance update failed because: Game update failed: it was impossible to fetch the required libraries.

This is due to library that I am trying to use not being in any remote repositories and therefore I had to get rid of "url" parameter.

Lassebq commented 3 months ago

A temporary workaround is to run the game in "Offline mode", which prevents libraries from being checked. But until a better solution is found, this issue remains open

Lassebq commented 3 months ago

Turns out it just needs an empty

            "downloads": {
            },

tag