search

MCPHackers / RetroMCP-Java

A rewrite of MCP to provide support for many versions of Minecraft which were never supported by original MCP
MIT License
226 stars 32 forks source link

Can't run ModLoader mods alongside compiled mod #40

Closed CyborgCabbage closed 8 months ago

CyborgCabbage commented 1 year ago

So I combine ModLoader, forge, and the mod I want to edit into "minecraft.jar" in the jars folder and (after fixing decompilation errors) everything works. The issue comes in when I add HowManyItems to "jars/mods" to help test the mod. crash.txt

Lassebq commented 1 year ago

Are you running with java 8? Also, RMCP runs deobfuscated mod by default. Check "Run build" parameter in launching options

Lassebq commented 1 year ago

You also have to build it first in order to run build

CyborgCabbage commented 1 year ago

Yes I am on Java 8. I have tried with obfuscation on and off. The mod I am developing builds just fine it's just when mod loader tries to load a mod from the mods folder instead of inside the jar that it crashes.

Lassebq commented 1 year ago

No, that's not what I'm saying. there's "Run build" option, use that. Obfuscation is just making mod classes obfuscated (in build) image Although this is a screenshot from a newer version, there's still an option like that. Enable it, then use context menu to launch client

Lassebq commented 1 year ago

Don't forget to run build task, as I said

CyborgCabbage commented 1 year ago

Yes I have tried with run build enabled and disabled, it has no effect on the error. I am also running the build task.

Lassebq commented 1 year ago

Would be helpful if you could provide info as to where and when it crashes and with what error

CyborgCabbage commented 1 year ago

I literally linked the crash text

Lassebq commented 1 year ago

Wait, I'm confused what is your mod? Is it HMI mod? or are you adding that separately alongside your mod? Do you have HMI deobfuscated? decompiled?

CyborgCabbage commented 1 year ago

No HMI is not the mod I am developing, I just want to run the game with it to make it easier to test my mod. I am adding HMI to the "jars/mods" folder so that mod loader can load it, but this does not work (resulting in error you see). Because of this issue I have always had to put the built mod into Prism to test it properly, but now I have a issue that is really difficult to debug without debugging tools so I would like to be able to load external mods from RetroMCP.

Lassebq commented 1 year ago

I see, apparently there was an issue with running build. It'll be fixed in the next release

CyborgCabbage commented 1 year ago

Cool thank you

Lassebq commented 1 year ago

Is this still an issue? Or does it work in v1.0?

CyborgCabbage commented 1 year ago

Still doesn't work, I did a bunch of debugging and I think the issue is that the deobfuscated.jar puts everything in net/minecraft/src whereas when you run the game they are all the root. I tried modifying launch wrapper to try a path with/without net.minecraft.src. when it can't find the class file but it didn't work, it freaks out because the Binary name in the file doesn't match the path (or something like that). I pushed the changes I made to a fork of LaunchWrapper so you can see what I am talking about (even though it didn't fix issue).

PhoenixVX commented 1 year ago

Can you provide a bit more information on the intended functionality of this?

Are you trying to run ML mods alongside a compiled (not reobfuscated) mod? If that's the case, this isn't intended to work. If it's something else, please say so.

PhoenixVX commented 1 year ago

Closing issue as inactive. Please reopen if the issue persists and is still in scope for RetroMCP-Java.