search

MCRcortex / nvidium

Fast minecraft rendering backend for sodium (nvidia only)
GNU Lesser General Public License v3.0
716 stars 82 forks source link

Incompability with Valkyrien Skies on 1.20.1 #235

Open McBenjihood opened 3 months ago

McBenjihood commented 3 months ago

Hey there, I run a modpack and I am using Nvidium to increase my fps because the modpack is very heavy (Thanks btw for the amazing mod).

I tried to add the mod valyrien skies today, but upon launching the game, a popup notified me, that apparently valyrien skies is incompatible with nvidium. According to this issue from valyrien skies github, the issue lies with nvidum and needs fixing on your end.

https://github.com/ValkyrienSkies/Valkyrien-Skies-2/issues/857#issuecomment-2143224071

I hope, that you maybe could look into this, as it is a known problem and would be nice if you are able to fix it. Thank you.

tileaves commented 3 months ago

Ran into the same issue today, would love a fix

EthanZeigler commented 3 months ago

From the issue description on valkyrian skies

Install VS, Embeddium, Acedium for Forge 1.20.1

AFAIK, and cortex can correct me on this if I'm wrong, Nvidium is a fabric mod with no official forge port. The issue you're describing, if it really is from the Nvidium renderer, needs to be fixed on the forge port.

If the forge port maintainers find the issue is because of a mistake in the official fabric version that's a different story, but this project can't do anything to fix bugs in ports until the maintainers know the port itself isn't the cause.

ferriarnus commented 3 months ago

From my understanding, this issue is also present with the fabric release of valkyrian skies? But I have to admit it was a while ago when I looked into it.

uczpre commented 3 months ago

Been like this since alpha ver lol