MCRcortex / voxy

An LoD rendering mod for minecraft
https://modrinth.com/mod/voxy
99 stars 16 forks source link

Border between lod chunks and normal chunks is visible in oceans #13

Open redstonerti opened 3 months ago

redstonerti commented 3 months ago

2024-03-03_17 55 37

I'm using the Faboulously optimized modpack and 3 extea mods: voxy, c2me and nvidium. I'm on windows playing fabric 1.20.4 and I have a 7700x and a 3060. I'm also playing on a server.

Oururis commented 2 months ago

This seems to be part of the mod rather than a bug the only solution is to increase render distance. But I have to say, that boundary line is really ug……, really doesn't look good.

Steveplays28 commented 2 months ago

It's supposed to be a pixel perfect cut/transition, weird that that happens, cortex might know more

redstonerti commented 2 months ago

This seems to be part of the mod rather than a bug the only solution is to increase render distance. But I have to say, that boundary line is really ug……, really doesn't look good.

Increasing render distance doesn't fix it at all. It just looks bad

Oururis commented 2 months ago

This seems to be part of the mod rather than a bug the only solution is to increase render distance. But I have to say, that boundary line is really ug……, really doesn't look good.

Increasing render distance doesn't fix it at all. It just looks bad

No, I meant , by increasing the render distance, you might not notice this issue as easily, like setting it to 32x (just kidding

CarloskHard commented 2 months ago

This could be fix with a transparent transition between real and lod chunks (Some shaders like complementary already do this on DH)

Steveplays28 commented 2 months ago

Transparency on Minecraft chunks introduces a lot of visual artifacts, unless the rendering pipeline is changed to split cutout/transparent and opaque rendering.

MeeniMc commented 2 months ago

There are two defects on that picture, one is at the transition between minecraft rendering and the lod rendering, where it seems the vertical water texture is rendered (possibly twice) resulting in the intense blue section; the second is that the second lod level appears to be rendered 1 block too high, but they are indeed mostly noticeable in water, but I have seen these black line appear also on ground terrain were it is more apparent that the elements are actually y+1 aligned.

Sorro123 commented 2 months ago

the second lod level appears to be rendered 1 block too high

I don't think that's the issue, I think it's because of water being not a full block.

redstonerti commented 2 months ago

There are two defects on that picture, one is at the transition between minecraft rendering and the lod rendering, where it seems the vertical water texture is rendered (possibly twice) resulting in the intense blue section; the second is that the second lod level appears to be rendered 1 block too high, but they are indeed mostly noticeable in water, but I have seen these black line appear also on ground terrain were it is more apparent that the elements are actually y+1 aligned.

The lod section being rendered higher has been fixed in 1.5.0, that's not an issue anymore

MeeniMc commented 2 months ago

Running 1dd2373f5 from runclient, zoomed onto the visible boundary, one can see that the 'black line' effect happens to the sand as well as the water. 2024-04-11_19 39 00 (Large) Moving forward just enough that a higher precision LOD is generated, this section shows that the sand was indeed rendered 1 block too high. 2024-04-11_19 42 09 (Large)

reference image (close enough to be in render distance)