MCS-Lite / mcs-lite

🎛 MCS Lite Common UI and Websites.
https://mcslite.netlify.com
MIT License
75 stars 9 forks source link

fix(Landing): We should use hydrate() here but got some problems with re-render #485

Closed evenchange4 closed 6 years ago

evenchange4 commented 6 years ago

Download Button did not re-render with correct os info

Issue:

What I did

How to test

evenchange4 commented 6 years ago

Deploy preview ready!

Built with commit a4affa2a13af8712ddfca63f790764438db278c6

https://deploy-preview-485--mcs-lite-ui.netlify.com

michaelhsu-bot commented 6 years ago
Warnings
:warning: Changes were made to package.json, but not to licenses.csv - Perhaps you need to run `$ yarn run license`?

Generated by :no_entry_sign: dangerJS

evenchange4 commented 6 years ago

Deploy preview ready!

Built with commit a4affa2a13af8712ddfca63f790764438db278c6

https://deploy-preview-485--mcslite.netlify.com

evenchange4 commented 6 years ago

Deploy preview ready!

Built with commit a4affa2a13af8712ddfca63f790764438db278c6

https://deploy-preview-485--mcs-lite-introduction.netlify.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #485 into master will decrease coverage by <.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   90.87%   90.86%   -0.01%     
==========================================
  Files         282      282              
  Lines        2345     2343       -2     
  Branches      133      133              
==========================================
- Hits         2131     2129       -2     
  Misses        173      173              
  Partials       41       41
Impacted Files Coverage Δ
...eb/src/components/DownloadButton/DownloadButton.js 100% <100%> (ø) :arrow_up:
packages/mcs-lite-landing-web/src/index.js 87.5% <50%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 962a4ab...a4affa2. Read the comment docs.