MCS-Lite / mcs-lite

🎛 MCS Lite Common UI and Websites.
https://mcslite.netlify.com
MIT License
75 stars 9 forks source link

chore(deps): update dependency styled-components to v3.2.2 #580

Closed renovate[bot] closed 6 years ago

renovate[bot] commented 6 years ago

This Pull Request updates dependency styled-components from v3.2.1 to v3.2.2

Release Notes ### [`v3.2.2`](https://github.com/styled-components/styled-components/releases/v3.2.2) #### Fixes ##### SSR accumulating non-critical CSS If you've noticed that v3.2 would cause your server-side rendered app to output all styles it knows of, you weren't alone! The `ServerTag` was accidentally cloning itself incorrectly. This meant that the `ServerStyleSheet` would inherit the same server styles from the “master” StyleSheet. We now clone the tag correctly and a test is in place to ensure this doesn't happen again, since this bug came up a couple of times in past v2 releases. Thanks to [@​DeividasK] for reporting this bug! ##### Fix at-rules nested inside style rules Have some styles gone missing? In the newer `>=3.1` versions that introduced speedy mode (i.e. `insertRule` support) some rules might not have been injected properly. This came down to `insertRule` being more strict with what we add. In development an incorrectly formatted CSS rule might not cause much trouble, but in production `insertRule` complains about it. `Stylis`, more specifically `stylis-rule-sheet`, was generating invalid CSS when at-rules were nested inside style rules. For instance the following CSS would cause trouble: ```css /* input */ &:hover { @​media (min-width: 768px) { color: papayahwip; } } /* incorrect output */ @​media (min-width: 768px) { &:hover { color: papayahwip; } }} /* ^ note the extra closing curly brace */ /* v3.2.2 fixed output */ @​media (min-width: 768px) { &:hover { color: papayahwip; } } ``` ##### Fix imprecise `IS_BROWSER` detection Before `v3.2.2` we would check whether styled-components is running inside the browser using: `typeof window !== 'undefined'`. This proofed insufficient in a couple of special cases for some people, so we have now added `'HTMLElement' in window` to this check. Thanks to [@​danieldunderfelt] for contributing this fix! ---
Commits #### v3.2.2 - [`36068ff`](https://github.com/styled-components/styled-components/commit/36068ff996481d5e96bfe24c08e4e36d3b475809) v3.2.2-1 - [`35d0f56`](https://github.com/styled-components/styled-components/commit/35d0f56cae5cd5df26e9bd96c5b218cc80f57dcf) Merge pull request #​1605 from styled-components/fix/servertag-clone - [`11f2f69`](https://github.com/styled-components/styled-components/commit/11f2f690df5648c85b06f9202cb8c2e7c6ae9809) Merge branch 'master' into better-browser-check - [`fa872e5`](https://github.com/styled-components/styled-components/commit/fa872e5779890008505923ec32ce278fcf2f95a6) Merge pull request #​1599 from danieldunderfelt/better-browser-check

This PR has been generated by Renovate Bot.

evenchange4 commented 6 years ago

Deploy preview for mcs-lite-ui ready!

Built with commit 04b534a4851c6ade2a2da40121ee73f71ae6d7c9

https://deploy-preview-580--mcs-lite-ui.netlify.com

michaelhsu-bot commented 6 years ago
Warnings
:warning: Please add a label to your PR.
:warning: Please assign someone to merge this PR, and optionally include people who should review.
:warning: Changes were made to package.json, but not to licenses.csv - Perhaps you need to run `$ yarn run license`?

Generated by :no_entry_sign: dangerJS

evenchange4 commented 6 years ago

Deploy preview for mcslite ready!

Built with commit 04b534a4851c6ade2a2da40121ee73f71ae6d7c9

https://deploy-preview-580--mcslite.netlify.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #580 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #580   +/-   ##
======================================
  Coverage    84.4%   84.4%           
======================================
  Files         319     319           
  Lines        2648    2648           
  Branches      169     169           
======================================
  Hits         2235    2235           
  Misses        352     352           
  Partials       61      61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aec78c...04b534a. Read the comment docs.

evenchange4 commented 6 years ago

Deploy preview for mcs-lite-introduction ready!

Built with commit 04b534a4851c6ade2a2da40121ee73f71ae6d7c9

https://deploy-preview-580--mcs-lite-introduction.netlify.com