evenchange4
commented
6 years ago Deploy preview for mcslite ready!
Built with commit 03980dc6a4b431a45a4a1f33a5d99ddb23091723
Closed renovate[bot] closed 6 years ago
evenchange4
commented
6 years ago Deploy preview for mcslite ready!
Built with commit 03980dc6a4b431a45a4a1f33a5d99ddb23091723
evenchange4
commented
6 years ago Deploy preview for mcs-lite-introduction ready!
Built with commit 03980dc6a4b431a45a4a1f33a5d99ddb23091723
https://deploy-preview-615--mcs-lite-introduction.netlify.com
evenchange4
commented
6 years ago Deploy preview for mcs-lite-ui ready!
Built with commit 03980dc6a4b431a45a4a1f33a5d99ddb23091723
michaelhsu-bot
commented
6 years ago | Warnings | |
|---|---|
| :warning: | Please add a label to your PR. |
| :warning: | Please assign someone to merge this PR, and optionally include people who should review. |
| :warning: | Changes were made to package.json, but not to licenses.csv - Perhaps you need to run `$ yarn run license`? |
Generated by :no_entry_sign: dangerJS
codecov[bot]
commented
6 years ago Merging #615 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 326 326
Lines 2691 2691
Branches 174 174
=======================================
Hits 2254 2254
Misses 372 372
Partials 65 65Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update d7da330...03980dc. Read the comment docs.
This Pull Request updates dependency danger from
v3.4.7tov3.6.5Release Notes
### [`v3.6.5`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#365) [Compare Source](https://github.com/danger/danger-js/compare/3.6.4...3.6.5) * Fix setting the status url on bitbucket [@orta][] * Adds more logs to `danger process` [@orta][] --- ### [`v3.6.4`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#364) [Compare Source](https://github.com/danger/danger-js/compare/3.6.3...3.6.4) * Fix running Danger on issues with no comments for real [@mxstbr][] --- ### [`v3.6.3`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#363) [Compare Source](https://github.com/danger/danger-js/compare/3.6.2...3.6.3) * Fix running Danger on issues with no comments [@mxstbr][] --- ### [`v3.6.2`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#362) [Compare Source](https://github.com/danger/danger-js/compare/3.6.1...3.6.2) * Automatically rate limit concurrent GitHub API calls to avoid hitting GitHub rate limits [@mxstbr][] --- ### [`v3.6.1`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#361) [Compare Source](https://github.com/danger/danger-js/compare/67ed2ba5e7dedf52f502393f50bfc21901ff8943...3.6.1) * Catch the github api error thrown from @octokit/rest [@Teamop][] * Replace preview media type of github pull request reviews api [@Teamop][] * Add support for [Screwdriver CI](http://screwdriver.cd) [@dbgrandi][] --- ### [`v3.6.0`](https://github.com/danger/danger-js/blob/master/CHANGELOG.md#360) [Compare Source](https://github.com/danger/danger-js/compare/3.5.1...67ed2ba5e7dedf52f502393f50bfc21901ff8943) * A Dangerfile can return a default export, and then Danger will handle the execution of that code [@orta][] * Changes the order of the text output in verbose, or when STDOUT is the only option [@orta][] * Prints a link to the comment in the build log [@orta][] #### 3.5.0 - 3.5.1 * Fixed a bug where Danger posts empty main comment when it have one or more inline comments to post [@codestergit][] * fix bug when commiting .png files on BitBucket [@Mifi][] * Adds support for inline comments for bitbucket server. [@codestergit][] #### 3.4.7 * Update dependencies [@orta][] #### 3.4.6 * Fixed Babel 7 breaking due to invalid sourceFileName configuration [@kesne][] #### 3.4.5 * Don't print error for commit status when there was no error [@sunshinejr][] #### 3.4.4 * Fixed a bug where Danger would get access to _all_ inline comments, thus deleting comments posted by other people [@sunshinejr][] #### 3.4.3 * Fixed a bug where updating multiple inline comments caused a Javascript error [@sunshinejr][] #### 3.4.2 * Improving reporting when multiple violations are o nthe same line of a file [@sunshinejr][] #### 3.4.1 * Protection against nulls in the inline comment data [@orta][] #### 3.4.0 * Adds support for inline comments when using GitHub. This is one of those "massive under the hood" changes, that has a tiny user DSL surface. From this point onwards `fail`, `warn`, `message` and `markdown` all take an extra two optional params: `file?: string` and `line?: number`. Adding `file` and `line` to the call of any exported communication function will trigger one of two things: * Danger will create a new comment inline inside your PR with your warning/message/fail/markdown * Danger will append a in the main Danger comment with your warning/message/fail/markdown Inline messages are edited/created/deleted with each subsequent run of `danger ci` in the same way the main comment does. This is really useful for: linters, test runners and basically anything that relies on the contents of a file itself. If you're using `danger process` to communicate with an external process, you can return JSON like: ```json { "markdowns": [ { "file": "package.swift", "line": 3, "message": "Needs more base" } ] // [...] } ``` -- [@sunshinejr][] * Adds a data validation step when Danger gets results back from a process . [@orta][] #### 3.3.2 * Adds support for TeamCity as a CI provider. [@fwal][] #### 3.3.1 * Fixed Babel 7 breaking because of sourceFileName being defined wrong. [@happylinks][] #### 3.3.0 * Fix `committer` field issue - missing in Stash API by using commit author instead. [@zdenektopic][] * Adds a new command: `reset-status` This command is for setting the CI build status in advance of running Danger. If your Danger build relies on running tests/linters, then you might want to set the PR status (the red/green/yellow dots) to pending at the start of your build. You can do this by running `yarn danger reset-status`. [@mxstbr][] #### 3.2.0 * Add BitBucket Server support. To use Danger JS with BitBucket Server: you'll need to create a new account for Danger to use, then set the following environment variables on your CI: * `DANGER_BITBUCKETSERVER_HOST` = The root URL for your server, e.g. `https://bitbucket.mycompany.com`. * `DANGER_BITBUCKETSERVER_USERNAME` = The username for the account used to comment. * `DANGER_BITBUCKETSERVER_PASSWORD` = The password for the account used to comment. Then you will have a fully fleshed out `danger.bitbucket_server` object in your Dangerfile to work with, for example: ```ts import { danger, warn } from "danger" if (danger.bitbucket_server.pr.title.includes("WIP")) { warn("PR is considered WIP") } ``` The DSL is fully fleshed out, you can see all the details inside the [Danger JS Reference][ref], but the summary is: ```ts danger.bitbucket_server. /** The pull request and repository metadata */ metadata: RepoMetaData /** The related JIRA issues */ issues: JIRAIssue[] /** The PR metadata */ pr: BitBucketServerPRDSL /** The commits associated with the pull request */ commits: BitBucketServerCommit[] /** The comments on the pull request */ comments: BitBucketServerPRActivity[] /** The activities such as OPENING, CLOSING, MERGING or UPDATING a pull request */ activities: BitBucketServerPRActivity[] ``` You can see more in the docs for [Danger + BitBucket Server](http://danger.systems/js/usage/bitbucket_server.html). -- [@azz][] * Don't check for same user ID on comment when running as a GitHub App. [@tibdex][] #### 3.1.8 * Improvements to the Flow definition file. [@orta][] * Improve path generator for danger-runner. [@Mifi][] * Update the PR DSL to include bots. [@orta][] #### 3.1.7 * Minor error reporting improvements. [@orta][] #### 3.1.6 * Move more code to only live inside functions. [@orta][] #### 3.1.5 * Fix --base options for danger local. [@peterjgrainger][] * Fix a minor typo in Semaphore CI setup. [@hongrich][] * Fix for capitalized Dangerfiles in CI environment. [@wizardishungry][] * Fix `danger local` crashing when comparing master to HEAD with no changes. [@orta][] #### 3.1.4 * Register danger-runner as a package binary. [@urkle][] #### 3.1.2-3.1.3 * Peril typings to the Danger DSL. [@orta][] * Reference docs updates for the website. [@orta][] #### 3.1.1 * Allows `danger runner` (the hidden command which runs the process) to accept unknown command flags (such as ones passed to it via `danger local`.) - [@adam-moss][]/[@orta][] #### 3.1.0 * Adds a new command `danger local`. This command will look between the current branch and master and use that to evaluate a dangerfile. This is aimed specifically at tools like git commit hooks, and for people who don't do code review. `danger.github` will be falsy in this context, so you could share a dangerfile between `danger local` and `danger ci`. When I thought about how to use it on Danger JS, I opted to make another Dangerfile and import it at the end of the main Dangerfile. This new Dangerfile only contains rules which can run with just `danger.git`, e.g. CHANGELOG/README checks. I called it `dangerfile.lite.ts`. Our setup looks like: ```json "scripts": { "prepush": "yarn build; yarn danger:prepush", "danger:prepush": "yarn danger local --dangerfile dangerfile.lite.ts" // [...] ``` You'll need to have [husky](https://www.npmjs.com/package/husky) installed for this to work. - [@orta][] * STDOUT formatting has been improved, which is the terminal only version of Danger's typical GitHub comment style system. It's used in `danger pr`, `danger ci --stdout` and `danger local`. - [@orta][] * Exposed a get file contents for the platform abstraction so that Peril can work on many platforms in the future - [@orta][] ##### 3.0.5 * Added support for Bitrise as a CI Provider - [@tychota][] ##### 3.0.5 * Nevercode ENV var fixes - [@fbartho][] ##### 3.0.4 * Paginate for issues - [@orta][] ##### 3.0.3 * Added support for Nevercode.io as a CI Provider - [@fbartho][] ##### 3.0.2 * Don't log ENV vars during a run - thanks @samdmarshall. - [@orta][] ##### 3.0.1 * Bug fixes and debug improvements. If you're interested run danger with `DEBUG="*" yarn danger [etc]` and you'll get a _lot_ of output. This should make it much easier to understand what's going on. - [@orta][] ##### 3.0.0 * Updates to the CLI user interface. Breaking changes for everyone. **TLDR** - change `yarn danger` to `yarn danger ci`. Danger JS has been fighting an uphill battle for a while with respects to CLI naming, and duplication of work. So, now it's been simplified. There are four user facing commands: * `danger init` - Helps you get started with Danger * `danger ci` - Runs Danger on CI * `danger process` - Like `ci` but lets another process handle evaluating a Dangerfile * `danger pr` - Runs your local Dangerfile against an existing GitHub PR. Will not post on the PR This release deprecates running `danger` on it's own, so if you have `yarn danger` then move that be `yarn danger ci`. Each command name is now much more obvious in it intentions, I've heard many times that people aren't sure what commands do and it's _is_ still even worse in Danger ruby. I figure now is as good a time as any a good time to call it a clean slate. On a positive note, I gave all of the help screens an update and tried to improve language where I could. - [@orta][] ##### 2.1.9-10 * Fix to `danger pr` and `danger` infinite looping - [@orta][] ##### 2.1.8 * Add a note in `danger pr` if you don't have a token set up - [@orta][] * Bunch of docs updates - [@orta][] ##### 2.1.7 * Fix Codeship integration - [@caffodian][] * Updates documentation dependencies - [@orta][] * Fixes to running `danger` with params - [@orta][] * Fixes for `danger pr` not acting like `danger` WRT async code - [@orta][] * Fixes `tsconfig.json` parse to be JSON5 friendly - [@gantman][] * Fixes for `danger.github.thisPR` to use the base metadata for a PR, I'm too used to branch workflows - [@orta][] ##### 2.1.6 * Updates dependencies - [@orta][] * Link to the build URL if Danger can find it in the CI env - [@orta][] * Removes the "couldn't post a status" message - [@orta][] ##### 2.1.5 * The TS compiler will force a module type of commonjs when transpiling the Dangerfile - [@orta][] ##### 2.1.4 * Adds a CLI option for a unique Danger ID per run to `danger` and `danger process`, so you can have multiple Danger comments on the same PR. - [@orta][] ##### 2.1.1 - 2.1.2 - 2.1.3 * Fixes/Improvements for `danger init` - [@orta][] ##### 2.1.0 * Adds a new command for getting set up: `danger init` - [@orta][] * Fix double negative in documentation. [@dfalling][] * Fix `gloabally` typo in documentation. [@dfalling][] ##### 2.0.2 - 2.0.3 * Adds a warning when you try to import Danger when you're not in a Dangerfile - [@orta][] * Exports the current process env to the `danger run` subprocess - [@orta][] ##### 2.0.1 * Potential fixes for CLI sub-commands not running when packaging danger - [@orta][] ##### 2.0.0 * Fixes the `danger.js.flow` fix to handle exports correctly, you _probably_ need to add `.*/node_modules/danger/distribution/danger.js.flow` to the `[libs]` section of your settings for it to work though - [@orta][] ##### 2.0.0-beta.2 * Fixes a bug with `danger.github.utils` in that it didn't work as of b1, and now it does :+1: - [@orta][] * Ships a `danger.js.flow` in the root of the project, this may be enough to support flow typing, thanks to [@joarwilk][] and [flowgen](https://github.com/joarwilk/flowgen) - [@orta][] ##### 2.0.0-beta.1 * Converts the command `danger` (and `danger run`) to use `danger process` under the hood. What does this do? * Dangerfile evaluation is in a separate process, run without a vm sandbox. This fixes the async problem which we created `schedule` for. Previously, any async work in your Dangerfile needed to be declared to Danger so that it knew when all of the work had finished. Now that the running happens inside another process, we can use the `on_exit` calls of the process to know that all work is done. So, _in Danger_ (not in Peril) async code will work just like inside a traditional node app. * Makes `danger process` a first class citizen. This is awesome because there will be reliable support for other languages like [danger-swift][], [danger-go][] and more to come. * The `danger process` system is now codified in types, so it's really easy to document on the website. * Adds a `--js` and `--json` option to `danger pr` which shows the output in a way that works with `danger process`. This means you can preview the data for any pull request. ./[@orta][] ##### 2.0.0-alpha.20 Moves away from vm2 to a require-based Dangerfile runner. This removes the sandboxing aspect of the Dangerfile completely, but the sandboxing was mainly for Peril and I have a plan for that. `https://github.com/danger/peril/issues/159` I would like to move the main parts of Danger JS to also work like `danger process`, so I'll be continuing to work as a alpha for a bit more. One interesting side-effect of this could be that I can remove `schedule` from the DSL. I've not tested it yet though. Turns out this change is _real_ hard to write tests for. I've made #394 for that. ./[@orta][] ##### 2.0.0-alpha.18 - 19 * Moves internal methods away from Sync to avoid problems when running in Peril - [@ashfurrow][] * Passes through non-zero exit codes from `danger process` runs - [@ashfurrow][] ##### 2.0.0-alpha.17 * Improve CircleCI PR detection ##### 2.0.0-alpha.16 Some UX fixes: * Don't show warnings about not setting a commit status (unless in verbose) - [@orta][] * Delete duplicate Danger message, due to fast Peril edits - [@orta][] * Show Peril in the commit status if inside Peril, not just Danger - [@orta][] * [internal] Tightened the typings on the commands, and abstracted them to share some code - [@orta][] ##### 2.0.0-alpha.15 * Updates `diffForFile`, `JSONPatchForFile`, and `JSONDiffForFile` to include created and removed files - #368 - bdotdub ##### 2.0.0-alpha.14 * Adds a blank project generated in travis 8 to test no-babel or TS integration - [@orta][] * Improvements to `danger process` logging, and build fails correctly #363 - [@orta][] ##### 2.0.0-alpha.13 * Improve the error handling around the babel API - #357 - [@orta][] * Move back to the original URLs for diffs, instead of relying on PR metadata - [@orta][] * Updates the types for `schedule` to be more accepting of what it actually takes - [@orta][] ##### 2.0.0-alpha.12 * Fixed #348 invalid json response body error on generating a diff - felipesabino * Potential fix for ^ that works with Peril also - [@orta][] ##### 2.0.0-alpha.11 * Doh, makes the `danger process` command actually available via the CLI - [@orta][] ##### 2.0.0-alpha.10 * Adds a `danger process` command, this command takes amn argument of a process to run which expects the Danger DSL as JSON in STDIN, and will post a DangerResults object to it's STDOUT. This frees up another process to do whatever they want. So, others can make their own Danger runner. An example of this is [Danger Swift][danger-swift]. It takes a [JSON][swift-json] document via [STDIN][swift-stdin], [compiles and evaluates][swift-eval] a [Swift file][swift-dangerfile] then passes the results back to `danger process` via [STDOUT][swift-stdout]. Another example is this simple Ruby script: ```ruby #!/usr/bin/env ruby require 'json' dsl_json = STDIN.tty? ? 'Cannot read from STDIN' : $stdin.read danger = JSON.parse(dsl_json) results = { warnings: [], messages:[], fails: [], markdowns: [] } if danger.github.pr.body.include? "Hello world" results.messages << { message: "Hey there" } end require 'json' STDOUT.write(results.to_json) ``` Which is basically Ruby Danger in ~10LOC. Lols. This is the first release of the command, it's pretty untested, but [it does work][swift-first-pr]. - [@orta][] [danger-swift]: https://github.com/danger/danger-swift [swift-json]: https://github.com/danger/danger-swift/blob/master/fixtures/eidolon_609.json [swift-stdin]: https://github.com/danger/danger-swift/blob/1576e336e41698861456533463c8821675427258/Sources/Runner/main.swift#L9-L11 [swift-eval]: https://github.com/danger/danger-swift/blob/1576e336e41698861456533463c8821675427258/Sources/Runner/main.swift#L23-L40 [swift-dangerfile]: https://github.com/danger/danger-swift/blob/1576e336e41698861456533463c8821675427258/Dangerfile.swift [swift-stdout]: https://github.com/danger/danger-swift/blob/1576e336e41698861456533463c8821675427258/Sources/Runner/main.swift#L48-L50 [swift-first-pr]: `https://github.com/danger/danger-swift/pull/12` ##### 2.0.0-alpha.9 * Uses the Babel 7 alpha for all source compilation with JS, Flow+JS and TS. This worked without any changes to our internal infra which is pretty awesome. All TS tests passed. Babel 7 is still in alpha, but so is Danger 2.0 - so I'm happy to keep Danger in a pretty long alpha, till at least Babel 7 is in beta. It also still supports using TypeScript via the "`typescript"` module, if you have that installed. - [@orta][] * `danger.github.thisPR` now uses the PR's head, not base - [@orta][] ##### 2.0.0-alpha.8 * Uses the GitHub `diff_url` instead of the `diff` version header, as it conflicted with Peril - [@orta][] * Handle exceptions in Dangerfile and report them as failures in Danger results - macklinu ##### 2.0.0-alpha.6-7 * Expose a Promise object to the external GitHub API - [@orta][] ##### 2.0.0-alpha.4-5 * Allow running a dangerfile entirely from memory using the `Executor` API - [@orta][] ##### 2.0.0-alpha.2-3 * Removes the `jest-*` dependencies - [@orta][] ##### 2.0.0-alpha.1 * Support [a vm2](https://github.com/patriksimek/vm2) based Dangerfile runner as an alternative to the jest infrastructure. There are a few main reasons for this: * I haven't been able to completely understand how Jest's internals work around all of the code-eval and pre-requisite setup, which has made it hard to work on some more complex Peril features. * Jest releases are every few months, personally I love this as a user of Jest, as an API consumer it can be difficult to get changes shipped. * The fact that both Danger/Jest make runtime changes means that you need to update them together * I have commit access to vm2, so getting changes done is easy I like to think of it as having gone from Jest's runner which is a massive toolbox, to vm2 which is a tiny toolbox where I'll have to add a bunch of new tools to get everything working. The _massive downside_ to this is that Danger now has to have support for transpiling via Babel, or from TypeScript unlike before, where it was a freebie inside Jest. Jest handled this so well. This means that a Dangerfile which used to "just work" with no config may not. Thus, IMO, this is a breaking major semver. Is it likely that you need to make any changes? So far, it seems probably not. At least all of the tests with Dangerfiles original from the older Jest runner pass with the new version. This is an alpha release, because it's knowingly shipped with some breakages around babel support, specifically: * Babel parsing of relative imports in a Dangerfile aren't working * Some of the features which require the `regeneratorRuntime` to be set up aren't working yet Those are blockers on a 2.0.0 release. ##### 1.2.0 * Exposes an internal API for reading a file from a GitHub repo as `danger.github.utils.fileContents` - [@orta][] Ideally this is what you should be using in plugins to read files, it's what Danger uses throughout the codebase internally. This means that your plugin/dangerfile doesn't need to rely on running on the CI when instead it could run via the GitHub API. * Update prettier - [@orta][] * Removes dtslint as a dependency - sapegin/orta ##### 1.1.0 * Support retrive paginated pull request commit list - kwonoj * Add support for VSTS CI - mlabrum * Remove the DSL duplication on the `danger` export, it wasn't needed or used. - [@orta][] * Update to TypeScript 2.4.x - [@orta][] * Rename github test static_file to remove `:` from the filename to fix a checkout issue on windows - mlabrum ##### 1.0.0 Hello readers! This represents a general stability for Danger. It is mainly a documentation release, as it corresponds toThis PR has been generated by Renovate Bot.