search

MCS-Lite / mcs-lite

🎛 MCS Lite Common UI and Websites.
https://mcslite.netlify.com
MIT License
75 stars 9 forks source link

feat(InputSelect): handle children as React element & expose itemValueMapper props #660

Closed liuderchi closed 6 years ago

liuderchi commented 6 years ago

To support trigger and action story where rendering svg in each menu item.

michaelhsu-bot commented 6 years ago
Warnings
:warning: Please add a label to your PR.
:warning: Please assign someone to merge this PR, and optionally include people who should review.

Generated by :no_entry_sign: dangerJS

evenchange4 commented 6 years ago

Deploy preview for mcs-lite-ui ready!

Built with commit 85fbbdac58ff8b96d422649be5df5d7a983333f5

https://deploy-preview-660--mcs-lite-ui.netlify.com

evenchange4 commented 6 years ago

Deploy preview for mcslite ready!

Built with commit 85fbbdac58ff8b96d422649be5df5d7a983333f5

https://deploy-preview-660--mcslite.netlify.com

evenchange4 commented 6 years ago

Deploy preview for mcs-lite-introduction ready!

Built with commit 85fbbdac58ff8b96d422649be5df5d7a983333f5

https://deploy-preview-660--mcs-lite-introduction.netlify.com

codecov[bot] commented 6 years ago

Codecov Report

Merging #660 into master will increase coverage by <.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   83.77%   83.77%   +<.01%     
==========================================
  Files         326      326              
  Lines        2693     2694       +1     
  Branches      174      174              
==========================================
+ Hits         2256     2257       +1     
  Misses        372      372              
  Partials       65       65
Impacted Files Coverage Δ
packages/mcs-lite-ui/src/Select/Select.js 100% <ø> (ø) :arrow_up:
packages/mcs-lite-ui/src/InputSelect/utils.js 91.66% <100%> (ø) :arrow_up:
...ackages/mcs-lite-ui/src/InputSelect/InputSelect.js 39.53% <50%> (+1.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffed90c...85fbbda. Read the comment docs.