MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
230 stars 163 forks source link

Custom Saplings/Trees bypass Anti-Grief plugins #272

Open AdvanceGamingNextLvl opened 10 years ago

AdvanceGamingNextLvl commented 10 years ago

At the request of rutgerkok, I have made a ticket here so you guys don't forget about this issue in the future. Original post here on the TC Forums: http://dev.bukkit.org/bukkit-plugins/terrain-control/forum/55872-terrain-control-2-6/?page=12#p226

Custom Saplings completely bypass anti-grief plugins. With Grief Prevention, custom trees that grow and over lap land claims don't get cut off. And CoreProtect is unable to log custom trees at all. This is a major issue that I feel needs to be fixed in the near future.

Example of a vanilla tree getting cut off when entering a Grief Prevention land claim and being logged with CoreProtect: vanilla

Example of a custom tree bypassing a Grief Prevention land claim and failing to be logged by CoreProtect: custom

rutgerkok commented 10 years ago

To implement this, we would need to modify the StructureGrowEvent.getBlocks() lost to match the contents of the BO2/3.

AdvanceGamingNextLvl commented 10 years ago

which would mean you have to bypass bukkit's internal code?