search

MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
230 stars 163 forks source link

Forge / Sponge 1.10 biome ID > 256 error #442

Closed Dockter closed 7 years ago

Dockter commented 8 years ago

Hello, I am using: terraincontrol-forge-2.8.2-SNAPSHOT.jar, under: spongeforge-1.10.2-2011-5.0.0-BETA-1567.jar.

Error: java.lang.RuntimeException: Invalid id 256 - maximum id range exceeded.

I attempted to load a previously loaded world and apparently ran out of Biome ID's. Note: previously this world worked fine under Cauldron 1.7.10.

Error Log: https://gist.github.com/mcsnetworks/f9b1791ff921a10e9b8ef7ff900fea39

WorldConfig.ini: https://gist.github.com/mcsnetworks/7d82ce38d4693d005d171a68b9546f21

Thoughts?

rutgerkok commented 8 years ago

Yeah, the Forge version is not really useable at the moment. Zidane suggested a fix using a placeholder biome, I will have to try something like that.

Dockter commented 8 years ago

Hello. Does your latest Forge commits address this issue?

rutgerkok commented 8 years ago

Not really. The crash should be gone, but the biome will show up as if it were the Plains biome.

Dockter commented 8 years ago

Does that mean that any biome ID that gets registered past 256 will be completely broken?

rutgerkok commented 8 years ago

The biome won't be registered, so it will show up as an unrecognized biome. Minecraft displays these as the plains biome.

Dockter commented 8 years ago

@rutgerkok from a generation stand point will it still work when the register with this message?

12:22:42 AM [INFO] [TerrainControl] Asked to register Grand_CRocksBorder with id 268, but succeeded with id 0 12:22:42 AM [INFO] [TerrainControl] Asked to register NethersCave with id 202, but succeeded with id 0 12:22:42 AM [INFO] [TerrainControl] Asked to register CanyonClosed with id 266, but succeeded with id 0 12:22:42 AM [INFO] [TerrainControl] Asked to register Nethers with id 128, but succeeded with id 0