search

MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
231 stars 161 forks source link

ReplaceToBiomeName not working #458

Closed lightningo7 closed 7 years ago

lightningo7 commented 8 years ago

I have several biomes set to replace to biome names and upon boot it says that they registered with biome ID 0.

TerrainControl v forge-2.8.2

Dockter commented 8 years ago

This is a known issue. The previous patch rut applied to the forge version was just duct tape to prevent the server crash.

Dockter commented 8 years ago

FYI @lightningo7 I am working to resolve this issue.

lightningo7 commented 8 years ago

Any ETA on when it'll be fixed? I look forward to having this working.

bloodmc commented 7 years ago

@mcsnetworks @lightningo7 Test my patched jar here

https://www.dropbox.com/s/6ioy6jgc2nuk1gn/terraincontrol-forge-2.8.2-1.10.2-B1.jar

Backup your world before testing. Please confirm if it works then I'll PR the fix so everyone benefits.

Here is the output with my fixed version

https://gist.githubusercontent.com/bloodmc/c8b3d85367d169095283aee1d923d345/raw/ced608f5c424fb6e518dca0aef951ef130c410f4/TerrainControl_startup.txt

Inscrutable commented 7 years ago

I've tested this with Forge 2185 (and SpongeForge 1.10.2-2171-5.1.0-BETA-1992) , and blood's test build holds water. Replacetobiome worked as expected; the test biome Flard (ID 666) generated as an amplified desert yet reported as a Flower Forest (ID 132). No errors whatsoever on console. Forge's biome registration changed sometime in the past, this has probably been around a while. This is also probably the same bug as Terrain Control issue #442

Dockter commented 7 years ago

I'll test this evening.