Update Forge to 1.11 and fix virtual biome registration.

[bloodmc]

This PR addresses tickets #442, #458, #475 by fixing virtual biome registration with Forge. I also updated Forge to 1.11 so it supports latest master.

There were 2 issues with the current code

• Forge blocking any biome registration with an ID > 255. Forge essentially creates a wrapper around the Biome registry in order to enforce rules such as ensuring the biome ID being registered doesn't surpass 255. While this is fine for the most part, it breaks support for virtual biomes which TerrainControl adds. To workaround the issue, I simply use reflection to bypass Forge's API and register the virtual biomes directly into the biome registry.
• WorldProvider init would cause TC to register the same world twice due to a bug in TCWorldType. I simply check to see if the world has been registered and if so setup the provider instance otherwise I run through normal TC loading logic.

For those on 1.10.2, you can find my virtual biome fix here

https://github.com/bloodmc/TerrainControl/tree/1.10.2

[Inscrutable]

I tested bloodmc's 1.10.2 build with Forge 2185 and the TC config from SoS8. Biomes were generated as expected, and replacetobiome also worked properly. The 1.11 version was not as solid (using Forge 2189), and needed the population bounds check disabled to function at all (and lagged a lot more).

[lightningo7]

I've been testing blood's 1.10.2 build and it's been working without any issues.

[rutgerkok]

Thanks a lot, @bloodmc!

I haven't tested it yet, but the code looks fine, so I'll just merge it.

[MCPitman]

@bloodmc @Inscrutable @lightningo7

I compiled blood's 1.10.2 build and 1.11 build and tried to run them with a client with no other mods (forge 2185 and 2189 respectively) and get this crash on load, any idea what I'm doing wrong?

http://pastebin.com/y5TrY2bt

[bloodmc]

I got another round of fixes that I'll PR soon. After server is fully functional, I'll fix client.

[bloodmc]

@MCPitman Please try my latest 1.10.2 branch here https://github.com/bloodmc/TerrainControl/tree/1.10.2

If it works out OK, I'll PR to update 1.11 forge.

[MCPitman]

@bloodmc

Different error on startup this time, same test as before with 1.10.2 client and 2185 forge.

http://pastebin.com/fatzbkVZ

[bloodmc]

Looks like you are not building it properly as the jar isn't getting remapped. Did you follow the compiling readme?

[MCPitman]

@bloodmc

Yes, followed these instructions: https://github.com/MCTCP/TerrainControl/blob/master/COMPILING.md

Here is the CMD window: http://i.imgur.com/NjS9JTl.png

Using JDK 8

[bloodmc]

@MCPitman Ah those instructions are wrong, you need to run the following gradlew clean build

Here is a correct build

https://www.dropbox.com/s/6ioy6jgc2nuk1gn/terraincontrol-forge-2.8.2-1.10.2-B1.jar

I tested it and had no issues creating a TC world.

[MCPitman]

Thanks @bloodmc will test it some and report back. It loaded Biome Bundle in single player and I saw some custom foliage colours so it's definitely working for the most part.

[MCPitman]

Have tested it extensively with hundreds of custom biomes and objects, including throwing it in the mix with other forge structure generation mods such as roguelike dungeons & recurrent complex which caused TC to crash in earlier TC forge releases (e.g. 1.7.10) and it all works flawlessly.

Stellar work @bloodmc this has made my day!

[ruyanve]

I can also confirm stability with recurrent complex and roguelike dungeons. I also threw in forestry and botania, to see if bee hives and flowers are generating and they did flawlessly. Cave decoration from WTF worked fine as well (performance issues are most probably from WTF). Ore generation was tested with WTF, which worked fine and custom ore generation which worked fine as well, except when I tried using BB and couldn't get ores to generate at all (probably caused by the way COG works). Thanks to @bloodmc !! Awesome job!