MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
230 stars 163 forks source link

Custom saplings do not get removed when tree grows #493

Open ghost opened 7 years ago

ghost commented 7 years ago

I have a .bc file containing all my custom saplings that is extended by every other biome. Previously I had only defined the custom saplings in this configuration file, but when players complained that other trees were not growing the correct tree, I added an entry for every type. Here is the changed portion of the config:

# All - will make the tree spawn from all saplings, but not from mushrooms.
# BigJungle - for when 4 jungle saplings grow at once.
# RedMushroom/BrownMushroom - will only grow when bonemeal is used.
Sapling(Oak,punkoak1,30,punkoak2,30,punkoak3,30,punkoak4,100)
Sapling(Redwood,punkspruce1,25,punkspruce2,25,punkspruce3,25,punkspruce4,100)
Sapling(Birch,punkbirch1,30,punkbirch2,30,punkbirch3,100)
Sapling(SmallJungle,CocoaTree,100)
Sapling(BigJungle,JungleTree,100)
Sapling(RedMushroom,HugeRedMushroom,100)
Sapling(BrownMushroom,HugeBrownMushroom,100)
Sapling(Acacia,Acacia,100)
Sapling(DarkOak,DarkOak,100)
Sapling(HugeRedwood,HugeTaiga1,50,HugeTaiga2,100)

The issue with this setup is that with the default tree models, saplings do not get removed when they grow into a tree. They remain planted and prevent the bottom block(s) of the tree from growing while the rest of the tree grows above the sapling. Players can continue to apply bonemeal to the sapling and more trees will grow into the same space. I fixed this with the custom tree models by adding saplings to their list of source blocks, but this probably isn't the best solution.