MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
230 stars 163 forks source link

No Forge Biome Dictionary support for custom biomes #500

Closed MCPitman closed 6 years ago

MCPitman commented 7 years ago

Mods that try to place flora/fauna according to biome or climate cannot do this without forge biome dictionary support and cause crashes when trying to spawn their content in Terrain Control biomes which do not have replacetobiomename set to a vanilla ID.

This is technically a feature request but I have reported it here since it causes crashes. Some crash reports are below:

IC2 Rubber Tree Generation crash: http://pastebin.com/eXbtZkZL

Pam's Havestcraft Beehive Generation crash: http://pastebin.com/iVrWjE7R

Also confirmed to happen with Mo' Creatures, and probably any other mods that try to detect Biome Dict tags to place worldgen features.

digi-tal-it commented 7 years ago

I can confirm this problem, in my tests the following mods caused a crash with Terrain Control:

codewarrior0 commented 7 years ago

IC2 Rubber Tree Generation crash: http://pastebin.com/eXbtZkZL

Getting a nearly identical crash.

terraincontrol-forge-2.8.2-1.10.2-B1.jar
industrialcraft-2-2.6.142-ex110.jar

Forge 12.18.3.2215
LiskoSlayer63 commented 7 years ago

I can confirm this problem too when using Mo' Creatures and also with Roguelike Dungeons. I hope that this will be fixed soon.

bloodmc commented 6 years ago

This is resolved in PR https://github.com/MCTCP/TerrainControl/pull/545

bloodmc commented 6 years ago

Fixed in latest snapshot.