search

MCTCP / TerrainControl

Minecraft Terrain Generator for SpigotMC and Forge
https://www.spigotmc.org/threads/terraincontrol.37980/
MIT License
230 stars 163 forks source link

[Forge] Fix a bunch of small annoying issues, backport Entity support #556

Closed Dockter closed 6 years ago

Dockter commented 6 years ago

Fix missing Forge Event calls. Fix missing calls for Mansions. Fix missing lookups for /locate command. Fix Temple Structure generations.

Signed-off-by: Dockter dockter@almuramc.com

rutgerkok commented 6 years ago

This pull request surely adds some nice features.

The code looks a bit unfinished to me. System.out.println calls, a method that is almost two hundred lines long, other methods consisting of just // TODO Auto-generated method stub. Blocks like this:

            catch (Exception exception)
            {
                exception.printStackTrace();
                return;
            }

Maybe it would be better to use ReflectiveOperationException instead, with TerrainControl.log methods?

It seems the code has just been copied from OpenTerrainGen. While the license allows this, it would have been nice to mention this. cc @PG85

I will merge it when I have some time to fix up the code.

Dockter commented 6 years ago

The only part that comes from OTG is the entity loading. I felt it wasn't necessary to mention it because he removed all mentions of OTG being a fork of TerrainControl.

Dockter commented 6 years ago

I will work at cleaning up the system.out.print's and try to get more stuff back to the actual logger.

Thanks for your consideration.

rutgerkok commented 6 years ago

Merged! I ended up rewriting the entity support. Entity(...) is now part of the block list. Because BO3 files do not care about the order, existing BO3 files from OpenTerrainGen should work fine.

PG85 commented 6 years ago

Hey guys, np, borrow whatever you like :). TerrainControl as well as the names of the original devs are still mentioned on the frontpage of the OTG git btw as well as in the mod description. If you feel credits are missing somewhere then it's no problem to add them, just let me know.