Two bugs: 1# game crashes if your modifier config has different mods with same value, #2 mod stops registering modifier configs for bows/curio/shield

[DezZzO]

Specific mod for which you open this issue

Remodifier

MC version & mod version

1.19.2, remodifier-1.19.2-2.2.1

Latest log

Crashlog for #1 - https://pastebin.com/P3Hwb1Ts, latest for #2 attached, too large for pastebin

Issue description

Example config for crash recreation number 1: {"name":"guarding","weight":200,"attributes":"minecraft:generic.armor;minecraft:generic.armor_toughness","amounts":"2;2","operationId":"0;0"}

Expected behavior for 1: possibility of having the same value for different stats in a multistat modifier

Expected behavior for 2: for mod to register modifiers latest.log

[Kasualix]

unzip me.zip Can you try if this build fix the first issue? I'm not sure whether or not the second is fixed

[DezZzO]

unzip me.zip Can you try if this build fix the first issue? I'm not sure whether or not the second is fixed

It fixes the first issue, same value stats are now possible, thanks!

Second issue remains, sadly, preventing the mod from detecting most of my configs. Providing latest.log for the second issue on the new mod version just in case it might help. latest.log

[Kasualix]

For the second issue, is it only the json file in the directories that can't accomplish the registration, and is the entry in toml able to take effect?

[DezZzO]

For the second issue, is it only the json file in the directories that can't accomplish the registration, and is the entry in toml able to take effect?

Tested it: .toml files also do not get registered. From random tests all I can say is that configs may sometimes get registered if I leave a small amount of unique modifier configs or delete all configs from a single category. By any chance registration breaks due to getting over some kind of limit? If I leave 30 total config files, every config loads, except for the curio one. If I add more - other categories will stop registering too.
Otherwise no useful info left, sorry.

[Kasualix]

unzip me.zip How about this build? I also add some more debug info here so it would be nice if you can upload your latest.log again if it still doesn't work on that version

[DezZzO]

unzip me.zip How about this build? I also add some more debug info here so it would be nice if you can upload your latest.log again if it still doesn't work on that version

No effect still, sadly, providing latest.log

latest.log

[Kasualix]

Can you share your configs?

[DezZzO]

Can you share your configs?

Sure, I put all the configs I had inside remodifiers_configs.zip

[Kasualix]

I think I know why: the modifiers' names get duplicated.

[Kasualix]

I suppose you could use different names in the json (e.g., for reinforced, you could try reinforced_curios, reinforced_armor, and reinforced_shield), but still translate them to the same name in the resourcepack made for display

[DezZzO]

I suppose you could use different names in the json (e.g., for reinforced, you could try reinforced_curios, reinforced_armor, and reinforced_shield), but still translate them to the same name in the resourcepack made for display

I had this theory about duped modifier names too, but, sadly, that's not the case, as removing the same named modifiers doesn't help And for some categories dupe names work just fine too I have the most issues with Curios folder config, as it sometimes doesn't want to register a single config file, even if all the other config folders are literally empty

[DezZzO]

Here's a short video demonstration: I have a single uniquely named config in every folder, yet it still doesn't work for Curio for example: https://www.youtube.com/watch?v=LPfpTiG_yQE

[Kasualix]

hmm, this setup works well for me. Do you have the WhetherOrNotCuriosUseArmorModifiers option disabled in curios-modifiers.toml? It is enabled by default

[Kasualix]

Well I was wrong, duplicate names works fine too

[DezZzO]

Do you have the WhetherOrNotCuriosUseArmorModifiers option disabled in curios-modifiers.toml? It is enabled by default

It is enabled for me indeed!

Well I was wrong, duplicate names works fine too

Yes, duped names and stats work for me also, the only issue is that some configs still refuse to load (currently NONE of the curios configs load, not just the armor ones).

UPD: Clear config reistall doesn't help. If I use all of my configs bows/curios/shields do not register as usual. WhetherOrNotCuriosUseArmorModifiers option doesn't help either.

[Kasualix]

I added some more jsons and it works too. The version I'm using: unzip me.zip

[DezZzO]

I added some more jsons and it works too. The version I'm using: unzip me.zip

This is the exact version I'm using too. It seems to work fine for me unless I go over certain amount of configs. If I use a few basic single-stat ones it seems to register them all. Add more and it stops registering them.

[Kasualix]

Odd, I didn't set a limit

[DezZzO]

So after another test: it worked fine when I had 2 unique configs in each folder, worked fine when I had 5 unique configs, but it stopped working when I went above 17 configs per folder.

If you'll have the spare time try to replicate the issue by adding more of my or any other configs into your folders.

I will try to test it out on a second machine tomorrow with a fully clear install of Minecraft and change mods around to see if some of them play the tricks on Remodifiers, but if the issue remains I'm absolutely out of ideas, as I'm clueless in code. Sorry to bother and thanks for trying to help! Will close the issue if clear install/removing conflicting mods help. GTG, as I'm already very sleep deprived.

[Kasualix]

Found errors in your config

[Kasualix]

supposed:

[Kasualix]

so do these two

[Kasualix]

Now I believe that's the reason. Should I crash the game if one config has errors?

[DezZzO]

Now I believe that's the reason. Should I crash the game if one config has errors?

Glad to hear it's a config error, though it's weird it prevents tons of other configs to load, but doesn't for some. Yes, crash on config error would be awesome. I've seen other mods even mention the exact wrong config line on config crash. Thanks!

[Kasualix]

A config option has been added to allow crash on config errors in the version I released last night (enabled by default), thanks for your report anyway.