search

MCTeamPotato / Kasualix-Issue-Tracker

Global issue tracker for my mods.
2 stars 0 forks source link

Redirect - Breaks Minecolonies *Investigating* #132

Open P3rf3ctXZer0 opened 5 months ago

P3rf3ctXZer0 commented 5 months ago

Specific mod for which you open this issue

Redirector + Minecolonies

MC version & mod version & loader version

Minecraft 1.20.1 Neoforge 47.1.104

Latest log

https://mclo.gs/os4eors

Issue description

Causes inventory and entity interaction to fail randomly with notice; "Minecoloines Inventory is Redirected"

Kasualix commented 5 months ago

Did remove redirector resolve your issue?🤔

P3rf3ctXZer0 commented 5 months ago

Seems to have.

Kasualix commented 5 months ago

Need some further information

I have never played minecolonies so also need some detailed steps to reproduce this

P3rf3ctXZer0 commented 5 months ago

Oh boy ... um so Minecolonies is Village Simulator by the dev Raycom and LDT team. (Lets dev toegether team.) I am not the best at explaining it I highly recommend you talk to their devs. They tend to use a lot of custom hooks and code so generally "Optimization mods" just tend to break them. (There code is already heavily optimize and they work on it constantly.) Anyways the villagers each have their own menus often controlled by this mod. https://github.com/ldtteam/BlockUI often peoples optimizations cause this menu specifically to break. "Interact Menu" also optimization mods frequent screw up "logic calls" or sim threads. I am not a coder so I am sure your better off talking to their devs and asking what your mod could be breaking. Or you can do what other devs do and simply tell your mod to not interact with Minecolonies or its dependancies in any way shape or form. I hope this clarifies things a little.

P3rf3ctXZer0 commented 5 months ago

Here full list of everything Minecolonies uses prismlauncher_iRHNVuSFUj 1

Kasualix commented 5 months ago

I mean, your current explanation cannot really let me know how did Redirector break your game. I need to reproduce your issue before fixing it

Kasualix commented 5 months ago

You can just make a list like - first entering the world - then opening your inventory etc And tell what's expected & fine and what's wrong

P3rf3ctXZer0 commented 5 months ago

The issue is its random ... so I am not sure what you can do. I can tell you symptoms. During multiplayer user claimed they could not long talk to or interact with villagers. After playing for a while. Relogging did not help they claimed and log said the spam I posted above each time they tried to interact. Restarting server didn't help and since I recently added your mod to my pack. I suspected since historically "Optimization" tends to break Minecolonies I removed it and it seemed to make a difference. That is really all the info I have. I can give you the users discord ID they don't have a Github. (Warning user is kind of worse at explaining things. especially tech.)

Kasualix commented 5 months ago

The spam info is harmless, it's just telling that redirector is working.

P3rf3ctXZer0 commented 5 months ago

So then its just the mod itself like I explained usually any code optimization breaks Minecolonies. I honestly suggest telling your mod to not touch or modify in any way the mods I listed. (this is likely what the devs will tell you too as I have been beta testing with them since 1.7.10)

P3rf3ctXZer0 commented 5 months ago

I will do what I can to figure out exactly why. If I can break down cause more I will let you know.

Kasualix commented 5 months ago

I will also test with your modlist later, before making progress you can just remove redirector from your server.

P3rf3ctXZer0 commented 5 months ago

Not sure if this helps but I keep my changelog for modpack on my community discord. https://discord.gg/ezddWfC9 your welcome to join this invite will expire in 7 days since its a direct link to changelog. Its an announcement channel so if you want to jump in take the channel and add it to an update channel on your group you can.